I disagree. Perhaps I am alone in this, but I often (used to) move to the end of the line, go back a few characters (to get inside parenthesis or something), and start typing. If there is trailing whitespace that I didn't know about I would be extremely annoyed because all my typing was in the wrong place. That's why I now show all trailing whitespace in my editor and have a draconian kill-all-trailing-whitespace-on-save policy. It has caused very few problems for me. I just have to remember to kill any hunks with whitespace only changes.
For those reasons I would love if we just got rid of trailing whitespace everywhere. Unfortunately, as you have mentioned, changing trailing whitespace causes hg/git to think that the line has changed thereby messing up blame etc. If there was a way to remove all whitespace from every revision ever when we change over to git, I think that would be awesome. I have no idea how much work it would be though, and there's always the slight chance you might break something that way. That said, I think the blame issue is more important than not having trailing whitespace, so I think C is a pretty good option. -Ivan On Nov 24, 2012, at 1:05 PM, Volker Braun <vbraun.n...@gmail.com> wrote: > You talk about trailing whitespace as if getting rid of it were a worthy goal > in itself. It is not. Humans don't care about trailing whitespace, we don't > see it unless you misconfigure your editor. Its purely for the benefit of > automated merge tools. If we disallow patch hunks that change trailing > whitespace only then the needs of merge tools are satisfied and there is no > further need for any policy beyond that. > > > On Saturday, November 24, 2012 11:55:24 AM UTC, P Purkayastha wrote: > C) We care about trailing whitespace. No new patches should introduce > trailing whitespace in modified lines. But patch hunks that ONLY change > trailing whitespace are disallowed. It is of course encouraged to get > rid of trailing whitespace in the code surrounding the lines your patch > touches. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To post to this group, send email to sage-devel@googlegroups.com. To unsubscribe from this group, send email to sage-devel+unsubscr...@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel?hl=en.
