On Sat, Jun 1, 2013 at 3:55 AM, leif <[email protected]> wrote: > John H Palmieri wrote: >> >> On Thursday, May 30, 2013 9:57:07 PM UTC-7, leif wrote: >> >> leif wrote: >> > Looks like reinstalling the Sage library spkg would meanwhile also >> > trigger the rebuild of *all* extension modules; not sure since when >> > though... (seen with Sage 5.10.beta5 at least) >> >> Yep. This is because #14570, merged into Sage 5.10.beta4, completely >> breaks sage-sync-build, which is also used in the Sage library's >> spkg-install. (sage -sync-build now removes all Cython-generated >> files, >> hence *all* have to get rebuilt afterwards.) >> >> >> IMHO both issues (complete rebuild upon cloning and after >> sage-sync-build) should be resolved before the final 5.10 gets out. >> >> >> The rebuild is dealt with at #13245 (needs partial review). > > > I'll revisit #13245 now that you've changed the ticket's title... ;-) > > [Avoiding also the rebuild of the fast_callable interpreters should be > feasable by just copying a few more files in sage-clone (I /think/ I already > did that), but I agree that's a minor issue, at least compared to rebuilding > the whole Sage library.] > > > >> Is there a ticket for the sage-sync-build problem? > > > Not yet. There are a couple of ways to (quickly or temporarily) "fix" this: > > 1) Unmerge #14570, which doesn't fix a bug, but only introduces a new (btw. > non-configurable) feature. [A bit odd, especially since #14570 also patches > the Cython spkg.] > > 2) Revert just #14570's change to setup.py, a one-liner (removing the > build_dir parameter to cythonize()). [Better than 1), although effectively > the same -- feature vanishes until we reenable it on some follow-up ticket.] > > 3) Make the behaviour configurable (defaulting to the previous; little > change to setup.py). No breakage to ordinary users; people using the new > feature are expected to know what they're doing, i.e., at least > sage-sync-build [still] won't work for them. [IMHO preferable for a > temporary / quick fix; easy and safe.] > > 4) Minimally adapt sage-sync-build.py to reflect the (hard-coded) change by > #14570. [May be easy as well, but potentially unsafe.] > > > I'd personally prefer 2) or 3) for now, postponing a "proper" solution to a > follow-up ticket which presumably won't make it into 5.10 (but hopefully > 5.11.*), as sage-sync-build needs some rework* anyway, the Cython build > directory (kind of VPATH) should IMHO be configurable, and #14570 might > cause further issues we haven't noticed yet. >
+1 to (2) or (3), along with the cython_version file fix, until we get build_dir working fully. - Robert -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
