On Monday, November 18, 2013 2:54:16 PM UTC-8, Nils Bruin wrote:
>
> I think the patchbot may have some trouble with patches correcting 
> whitespace.
>

Actually, looking at the output of the whitespace plugin, I noticed the 
whitespace report is *per patch*, where a patch is extracted for each 
commit. So the plugin is catching the whitespace introduced in an earlier 
commit but doesn't see that the same whitespace errors are corrected in a 
subsequent patch. I guess folding the whitespace correction into a commit 
would fix the problem.

Perhaps the whitespace plugin should analyse a patch reflecting the diff of 
the entire branch relative to the chosen base rather than patches for each 
commit individually?

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to