Jeroen Demeyer wrote: > OK, thanks, at least I understand the issue now. Somehow I couldn't > find this very simple explanation on the other long thread about > dependencies.
I'm not sure which of the threads about dependencies you are referring to, but Volker gave the same example (and more) in the thread starting at <[email protected]>. See in particular <[email protected]>. Btw, I'm still not convinced by Volker's explanations, and the policy I was suggesting at the beginning of that thread still makes more sense to me. In summary, here's what I was suggesting: 1. The default diff/commits view of a ticket T linked from its trac page should be something like git log --graph commit ^trac/develop ^dep1 ^dep2 ... where commit is the contents of T's Commit field and dep1, dep2... are the contents of the Commit fields of the tickets D1, D2... listed in T's Dependencies field. Setting T to positive_review means that the set of commits described by the above "git log" command has been reviewed. 2. Any change to that set of commits (any change to T's Commit field, any change to one of the D's Commit fields that modifies its most recent common ancestor with T's Commit) automatically reverts T to needs_review. 3. It is allowed, though discouraged, to review T without reviewing D1, D2... If anyone can explain why "Volker's model" is safer than that, I'm very interested. In particular, Volker has given a number of examples of how mathematically incorrect code can end up in the mainline despite the reviewers having done their job. But the simple fact of reviewing several branches in parallel is enough to have kind of problems, even if there are no dependencies between the branches! And I'm still looking for an situation where the way of handling dependencies outlined above, specifically, would cause a problem. Thanks! -- Marc -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/groups/opt_out.
