Hi,
Le 26/09/2014 17:04, Jeroen Demeyer a écrit :
On 2014-09-26 16:42, Julien Puydt wrote:
I don't think it's good to patch upstream and ship it as if it were
upstream.
What do you mean with "ship it as if it were upstream"? It's not like we
hide the fact that PARI is patched.
A good distribution doesn't patch further than what is needed to package.
It would be better to add functionality to sage-over-pari instead of
PARI-in-sage...
Even better would be to have PARI upstream accept these patches, but we
have no control over that.
Upstream doesn't find the idea interesting, here on the ml people don't
find the idea interesting... perhaps it's just not worth it?
* infinity.patch: PARI has a new infinity type but in upstream's
version, this type is almost useless. My patch allows basic arithmetic
(like 2*oo gives oo), which is needed to not break Denis Simon's
scripts.
Rejected by upstream because "Purposefully, we restricted the semantic
attached to oo. Most of the time such operations are the symptom of a
bug."
Is the problem really on PARI's side or on the scripts' side?
Depends on which side you're on... I would say PARI caused the problem
since they have changed the documented behaviour of a function.
Upstream's reaction: "Well, but who would use it ?"
Well... the question is good, isn't it?
Sage would certainly use it, but apparently that's not good enough.
Who would use that seriously in sage? From what you have explained, I
gather that you prefer forking a well-maintained upstream rather than
modify a bunch of unmaintained scripts...
don't patch needlessly, and if you think you need it,
think better -- can't it go in sagelib instead?
I disagree with this. I think we should put code in the most logical
place where it belongs. Given that PARI already has an implementation
for isprimepower(), it is easier and more natural to implement
ispseudoprimepower() in PARI than in Sage.
It doesn't seem that natural, and forking isn't easy... for two lines in
sagelib!
Snark on #sagemath
--
You received this message because you are subscribed to the Google Groups
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.
