On Thu, Jun 11, 2015 at 1:24 PM, David Perkinson <dav...@reed.edu> wrote: > Yes, I think it will be much more efficient to address these changes all at > once. I would really prefer that, if possible. >
I downloaded the code as a tarball and "manually" installed it (as opposed to using git). I didn't find any problems with any of the code, but only looked at one (the RR dim function) line-by-line. Caroline and I wrote a function which did the same thing but used a slightly different algorithm (and also implemented in a completely different way). You're is much faster, but yielded the same results as ours. I tested out a few of the other basic ones and they also worked as expected. Personally, I don't like the dictionary-based notation you used and switched away from it in my own code. However, i don't recommend you change to my notation! It's just that I prefer writing things another way. Great job. Thank you, and I hope it gets incorporated into Sage one day! > I had seen the "reasons-to-invalidate-tickets" statement but was hoping this > was a guideline, subject to context, and not a law. > > Thanks. > > > On Thursday, June 11, 2015 at 8:31:29 AM UTC-7, kcrisman wrote: >> >> >>> >>> http://doc.sagemath.org/html/en/developer/trac.html#reasons-to-invalidate-tickets >> >> >> I think what Nathann is trying to say is that it might be good to split >> this up into smaller pieces. However, given the trouble you had getting git >> to work, that might be something somewhat technically infeasible without >> some help. >> >> That said, I've seen worse ;-) David, this looks like a great piece of >> work - do you have some colleagues or students who might be able to help >> review it without breaking it into smaller pieces? > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at http://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
