On Wednesday, 6 January 2016 22:13:02 UTC, Dima Pasechnik wrote: > > On 6 January 2016 at 21:13, Volker Braun <> wrote: > > A slightly more useful solution would be to put the gap code into a gap > file > > in src/ext/gap/ and load it from there. For starters, it could then also > be > > loaded into a plain gap session. >
I can call libgap.Read() from outside the function body, thus it will only be Read once. What I don't like that this piece of GAP code will be hidden, with ?? not showing it, and it won't be mentioned in the documentation either (at least not automatically). (although surely this would help with its syntax highlighting --- something the reviewer complains about :-)) Jeez, I don't understand why I spent my time researching how to write something in a more efficient way, cf e.g. attachments on the ticket, this: http://mathoverflow.net/questions/227540/embedding-of-o-4-q-in-u-4q and half a dozen emails to an author of the construction I implemented, etc, in order just to hear from the reviewer that I "should instead expose in the Sage mathematical objects those features from GAP that you need" (could anyone translate this for me?) and that he "was just looking at the GAP code (and getting scared)" and he won't review it because I put few lines of GAP code in a string. Dima > I never heard about src/ext/gap/ - is it documented anywhere? > Does libGAP know about it in some way? > > > > > > Either way it doesn't really win any beauty contents, but then its just > > constructing a particular named graph. Once that works there isn't going > to > > be much ongoing development on that particular named graph, so I don't > > really care too much about it. > > > > > > > > > > > > On Wednesday, January 6, 2016 at 9:48:42 PM UTC+1, Nathann Cohen wrote: > >> > >> Hello everybody, > >> > >> A ticket is in needs_review at #19661 [1], and the branch's main > >> feature is a new graph constructor. I write here because of a > >> disagreement Dima and I have about the code: I do not like at all that > >> most of the code is a *string* that is sent to GAP for evaluation. > >> > >> > >> > http://git.sagemath.org/sage.git/diff/?id2=036455fd4defbb003152bf283af3a629b9c49324&id=16f1f711fce54ae770c81dd957e5cad2baea8fe1 > > >> > >> The result of the computation is of course returned to the user as a > >> Sage object. > >> > >> Dima says that he does not understand what my objection is, and so I > >> write here hoping that you will help me make it clear or tell me that > >> I am wrong to complain about this. > >> > >> Have fun, > >> > >> Nathann > >> > >> [1] http://trac.sagemath.org/ticket/19661 > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
