On Wednesday, August 17, 2016 at 8:55:38 AM UTC+1, Simon King wrote: > > Hi Dima, > > On 2016-08-16, Dima Pasechnik <dim...@gmail.com <javascript:>> wrote: > > I don't see why you ever need to mark tests in a module X, which only > > depend on X being installed, optional; after all if X is not > > installed then the tests are not there, and if X is installed then it's > > there... > > The .pyx wrapper for X definitely is in the Sage sources regardless > whether > X is installed or not. Just have a look at > src/sage/matrix/matrix_gfpn_dense.pyx, which is there although probably > you did not install the optional meataxe package. > > And if I understand correctly, an OptionalExtension is even cythoned > regardless whether X is installed or not. However, the corresponding > Python extension module is only created if X is available. > > > Naturally if X can be used in a module Y<>X then the corresponding tests > > will need to be optional, but IMHO in your case it's pretty small number > of > > tests to tag. > > In my local branch, > grep " sage: " -R src/sage/groups/modular_cohomology/ |wc -l > 5268 > > Is that a small number? >
Do you mean to sat that src/sage/groups/modular_cohomology/ would be standard, and relying on meataxe at the same time (i.e., useless without meataxe) ? IMHO it might be better to make it optional, and dependent on meataxe. This way if it is installed then meataxe is installed, too, and you can doctest without #optional tags just fine. Dima > > Best regards, > Simon > > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
