On Wed, 9 Nov 2016, Amritanshu Prasad wrote:

Yes, I have. It's all on a trac ticket:

https://trac.sagemath.org/ticket/21729

OK. The code seems to be clear. However, there is already has_multiple_edges() on (di)graphs, so "is_simple"-part is not needed. Did you search for a function to check if a graph is simple? If so, and did not found this, then the documentation of has_multiple_edges() should be enchanced.

Is "is_simple_deterministic" meant to be used as it's own? If not, it can be made a subfunction to is_cayley_directed. Kind of middle solution is to make it _is_simple_deterministic(), so it won't show up in <tab>-completion or html documentation.

is_cayley_directed() has no explanation of what is a Cayley graph.

I haven't read the paper, so I can not comment about the idea.

--
Jori Mäntysalo

Reply via email to