On Mon, Jul 17, 2017 at 10:45 AM, Erik Bray <erik.m.b...@gmail.com> wrote:
> On Sat, Jul 15, 2017 at 2:18 PM, Simon King <simon.k...@uni-jena.de> wrote:
>> On 2017-07-15, Simon King <simon.k...@uni-jena.de> wrote:
>>> That's exactly why my suggestion is good: The patchbots should verify
>>> that all tests pass with any subset of the optional packages that
>>> are dealt with in the ticket (of course including the empty subset).
>> On second thought: My suggestion wouldn't work, since Sage isn't able
>> to properly uninstall optional packages. Or has that changed?
> Right, it wouldn't be able to uninstall them properly, but I'm nearing
> a quite effective solution to that [1].
> Other than that annoying technical shortcoming I think your suggestion
> does make sense.  It makes perfect sense that if a ticket specifically
> impacts code that uses an optional package, then that optional package
> should be installed to run the tests for better coverage.
> [1] https://trac.sagemath.org/ticket/22510

As a followup, so we don't lose track, could you open an issue for
that on the patchbot's issue tracker?

This would also require some modification to the Trac server's
configuration to add the additional ticket field, but that's simple

You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to