On Tue, Dec 19, 2017 at 1:22 PM, Jeroen Demeyer <[email protected]> wrote: > On 2017-12-19 12:17, Erik Bray wrote: >> >> It's *attempting* to validate that the >> doctest parser skips tests when it's supposed to. > > > Actually, it's also the converse. > > Sometimes people write stuff like > """ > EXAMPLES:: > > sage: .... > """ > in random strings which aren't actually docstrings. The naive parser checks > for such strings regardless of where they occur. If such a string is not in > a docstring, the _test_enough_doctests test will catch it.
I'm not sure why that matters. Do you mean you need some test to make sure that a test someone wrote is actually being run? Or the opposite? I'm a little confused by this. > But it also validates the doctest framework. I remember fixing some quoting > issue in the doctest parser which was caught thanks to this doctest. > >> I would propose to just remove the test. > > > -1. The test is useful. If there were a quoting issue in the doctest parser that happened to be caught by...a different parser, then that was pure luck. It would be better to write regression tests against the actual parser. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
