On Tue, May 22, 2018 at 10:14 PM, Victor Porton <[email protected]> wrote: > I committed a new feature of Sage 4 months ago. It is now needs_review. Why > is it not yet accepted? Is something wrong? Or should I just wait more? > > https://trac.sagemath.org/ticket/24542
Hi Victor, I think you're not quite asking the right question--it assumes that your patch definitely will be accepted just as-is, and that's a big assumption, especially considering that it adds things like a new top-level package to Sage. Assuming that there isn't already a way to do what you're doing with Sage, and that this definitely is a useful contribution (which I don't doubt, though I'm not necessarily qualified to make that determination), then I'm sure some version of your patch *will* be accepted eventually (and even as-is I know it's not ready due to the proliferation of "TODO" comments in the code). I would instead just ask, "Why hasn't my patch been reviewed yet?" That's a fair question to ask though the answer is pretty simple, and Ralf already gave it. But it's perfectly reasonable to give a poke if you feel your contribution hasn't received due attention! If you want I can at least provide some nitpicks on the implementation details, though others should comment on how this fits into Sage overall. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
