On 17 December 2013 17:48, Volker Braun <[email protected]> wrote: > You need to manually change the Branch: field on the ticket. Trac can't know > yet that you want to attach that newly-created branch to the ticket. The > commit field is filled out automatically for you.
Thanks, I have now done that. To expand: after the manual changes to the Branch field are saved, trac automatically updates the Commit field. Neither happens just by pushing a new commit to trac. I suppose that is because with a plain git command, the trac repository cannot know which ticket is the relevant one; and that was one thing which the sage-dev version could do more cleverly. The upshot is that I have (at last!) completed by first ever review using the git system, including adding some reviewer's fixups. And perhaps all my questions about this should have been on sage-devel rather than sage-git. Too bad. John > > > > On Tuesday, December 17, 2013 5:42:16 PM UTC, John Cremona wrote: >> >> On 17 December 2013 17:25, Volker Braun <[email protected]> wrote: >> > You only have write permissions for branches named u/cremona/... or >> > public/... >> > >> > To push the current local branch to u/cremona/8723 (or pick a better >> > description if you want): >> > >> > git push trac HEAD:u/cremona/8723 >> > >> > This is also in the developer guide >> > SAGE_ROOT/src/doc/output/html/en/developer/manual_git.html under >> > "Pushing >> > Your Changes to a Ticket". >> > >> >> OK, my mistake, sorry. (That part of the manual should be renamed to >> something other than "Git the hard way" !!) >> >> Your instructions worked, at leadst in the sense that the output from >> the git command suggested that it had done the right thing, but I >> cannot see the new branch (called u/cremona/8723) on the trac ticket. >> I guess that is something extra which the dev script would have seen >> to? Do I need to do more? Should I manually change the ticket fields >> branch (to u/cremona/8723) and commit (to >> 1fec98388ed6689f1ec86c9b32f5bf298122c320) ? >> >> Thank you for your patience. >> >> John > > -- > You received this message because you are subscribed to the Google Groups > "sage-git" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "sage-git" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
