Dominique. - you should send a pull request. Thanks. On Saturday, July 16, 2016, Dominique Laurain <[email protected]> wrote:
> > Just read code at : https://github.com/williamstein/sage_modabvar > My raw (and low level) comments below from my test on sagemath cloud > terminal > >> >> ~$ sage -v >> SageMath Version 6.10, Release Date: 2015-12-18 >> ~$ sage-develop -v >> SageMath version 7.3.beta7, Release Date: 2016-07-08 > > > ~$ sage-develop -t --force-lib sage_modabvar >> init.sage does not exist ... creating >> Running doctests with ID 2016-07-17-06-04-30-644d7d3c. >> Git branch: develop >> Using --optional=mpir,python2,sage >> Traceback (most recent call last): >> File "/projects/sage/sage-dev/src/bin/sage-runtests", line 89, in >> <module> >> err = DC.run() >> File >> "/projects/sage/sage-dev/local/lib/python2.7/site-packages/sage/doctest/control.py", >> line 1128, in run >> self.expand_files_into_sources() >> File >> "/projects/sage/sage-dev/local/lib/python2.7/site-packages/sage/doctest/control.py", >> line 734, in expand_files_into_sources >> self.sources = [FileDocTestSource(path, self.options) for path in >> expand()] >> File >> "/projects/sage/sage-dev/local/lib/python2.7/site-packages/sage/doctest/sources.py", >> line 498, in __init__ >> raise ValueError("unknown file extension %r"%ext) >> ValueError: unknown file extension '' > > > OK : just try to install it => Comment 1 : where is the "init.sage" file ? > > >> ~$ sage-develop setup.py develop --user >>> python: can't open file 'setup.py': [Errno 2] No such file or directory >>> OK : of course... I have to get a git copy => Comment 2 : write in >>> README.md the exact commands for the cloud or add a short note "git >>> knowledge is pre-requisite" (for users like me, newbie in git) >>> ~$ git clone https://github.com/williamstein/sage_modabvar.git >>> Cloning into 'sage_modabvar'... >>> remote: Counting objects: 229, done. >>> remote: Compressing objects: 100% (7/7), done. >>> remote: Total 229 (delta 0), reused 0 (delta 0), pack-reused 222 >>> Receiving objects: 100% (229/229), 196.98 KiB | 0 bytes/s, done. >>> Resolving deltas: 100% (112/112), done. >>> Checking connectivity... done. >> >> > OK : in the current directory, I get a sage_modabvar sub-directory > >> >> ~$ cd sage_modabvar >> ~/sage_modabvar$ ls >> ~/sage_modabvar$ ls >> README.md sage_modabvar setup.py > > > OK : try again to install it > >> >> ~/sage_modabvar$ sage-develop setup.py develop --user >> running develop >> running egg_info >> creating sage_modabvar.egg-info >> writing sage_modabvar.egg-info/PKG-INFO >> writing top-level names to sage_modabvar.egg-info/top_level.txt >> writing dependency_links to sage_modabvar.egg-info/dependency_links.txt >> writing manifest file 'sage_modabvar.egg-info/SOURCES.txt' >> writing manifest file 'sage_modabvar.egg-info/SOURCES.txt' >> Processing dependencies for sage-modabvar==0.1 >> running build_ext >> Creating >> /projects/6429970e-5a78-4aee-a6b1-af1e80542481/.sage/local/lib/python2.7/site-packages/sage-modabvar.egg-link >> (link to .) >> Adding sage-modabvar 0.1 to easy-install.pth file >> Finished processing dependencies for sage-modabvar==0.1 >> >> Installed /projects/6429970e-5a78-4aee-a6b1-af1e80542481/sage_modabvar > > > OK : that's better => Comment 3 : add to README.md , after install just cd > into directory containing .sage and the sage-modabvar directory > >> >> ~$ sage-develop -t --force-lib sage_modabvar >> no stored timings available >> Running doctests with ID 2016-07-17-06-21-59-bbdb079d. >> Git branch: develop >> Using --optional=mpir,python2,sage >> Doctesting 14 files. >> sage -t sage_modabvar/setup.py >> [0 tests, 0.00 s] >> sage -t sage_modabvar/sage_modabvar/abvar_ambient_jacobian.py >> [64 tests, 4.27 s] >> sage -t sage_modabvar/sage_modabvar/cuspidal_subgroup.py >> [82 tests, 1.97 s] >> sage -t sage_modabvar/sage_modabvar/lseries.py >> [69 tests, 23.73 s] >> sage -t sage_modabvar/sage_modabvar/torsion_subgroup.py >> [96 tests, 7.62 s] >> sage -t sage_modabvar/sage_modabvar/abvar_newform.py >> ********************************************************************** >> File "sage_modabvar/sage_modabvar/abvar.py", line 2256, in >> sage_modabvar.abvar.ModularAbelianVariety_abstract.frobenius_polynomial >> Failed example: >> J.frobenius_polynomial(7) >> Exception raised: >> Traceback (most recent call last): >> File >> "/projects/sage/sage-dev/local/lib/python2.7/site-packages/sage/doctest/forker.py", >> line 498, in _run >> self.compile_and_execute(example, compiler, test.globs) >> File >> "/projects/sage/sage-dev/local/lib/python2.7/site-packages/sage/doctest/forker.py", >> line 861, in compile_and_execute >> exec(compiled, globs) >> File "<doctest >> sage_modabvar.abvar.ModularAbelianVariety_abstract.frobenius_polynomial[8]>", >> line 1, in <module> >> J.frobenius_polynomial(Integer(7)) >> File >> "/projects/6429970e-5a78-4aee-a6b1-af1e80542481/sage_modabvar/sage_modabvar/abvar.py", >> line 2274, in frobenius_polynomial >> self.decomposition())) >> File "sage/misc/misc_c.pyx", line 126, in sage.misc.misc_c.prod >> (/projects/sage/sage-dev/src/build/cythonized/sage/misc/misc_c.c:1860) >> return iterator_prod(x, z) >> File "sage/misc/misc_c.pyx", line 208, in >> sage.misc.misc_c.iterator_prod >> (/projects/sage/sage-dev/src/build/cythonized/sage/misc/misc_c.c:2346 >> ) >> sub_prods = [next(L)] * 10 >> File >> "/projects/6429970e-5a78-4aee-a6b1-af1e80542481/sage_modabvar/sage_modabvar/abvar.py", >> line 2273, in <genexpr> >> return prod((s.frobenius_polynomial(p) for s in >> File >> "/projects/6429970e-5a78-4aee-a6b1-af1e80542481/sage_modabvar/sage_modabvar/abvar.py", >> line 2297, in frobenius_polynomial >> Gp = ap.charpoly(var='x') >> TypeError: charpoly() takes no keyword arguments >> ********************************************************************** >> File "sage_modabvar/sage_modabvar/abvar.py", line 2260, in >> sage_modabvar.abvar.ModularAbelianVariety_abstract.frobenius_polynomial >> Failed example: >> J.frobenius_polynomial(3, var='y') >> Exception raised: >> Traceback (most recent call last): >> File >> "/projects/sage/sage-dev/local/lib/python2.7/site-packages/sage/doctest/forker.py", >> line 498, in _run >> self.compile_and_execute(example, compiler, test.globs) >> File >> "/projects/sage/sage-dev/local/lib/python2.7/site-packages/sage/doctest/forker.py", >> line 861, in compile_and_execute >> exec(compiled, globs) >> File "<doctest >> sage_modabvar.abvar.ModularAbelianVariety_abstract.frobenius_polynomial[10]>", >> line 1, in <module> >> J.frobenius_polynomial(Integer(3), var='y') >> File >> "/projects/6429970e-5a78-4aee-a6b1-af1e80542481/sage_modabvar/sage_modabvar/abvar.py", >> line 2297, in frobenius_polynomial >> Gp = ap.charpoly(var='x') >> TypeError: charpoly() takes no keyword arguments >> ********************************************************************** >> 1 item had failures: >> 2 of 15 in >> sage_modabvar.abvar.ModularAbelianVariety_abstract.frobenius_polynomial >> [752 tests, 2 failures, 21.03 s] >> sage -t sage_modabvar/sage_modabvar/constructor.py >> [15 tests, 0.44 s] >> sage -t sage_modabvar/sage_modabvar/torsion_point.py >> [46 tests, 0.61 s] >> ---------------------------------------------------------------------- >> sage -t sage_modabvar/sage_modabvar/abvar.py # 2 doctests failed >> ---------------------------------------------------------------------- >> Total time for all tests: 90.2 seconds >> cpu time: 75.3 seconds >> cumulative wall time: 84.0 seconds > > > NOK : some doctests have failed => Comment 4 : after you tag/publish an > "official release" on git, ALWAYS runs the > doctests like me (usually potential users of your code don't want to > debug it) > > About my comments : "Keep it cool" :-) ... I thank you for this painful > task of coding and narrowing the gap between sagemath and other math > software. > > Dominique > > -- > You received this message because you are subscribed to the Google Groups > "sage-nt" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <javascript:_e(%7B%7D,'cvml','sage-nt%[email protected]');>. > To post to this group, send email to [email protected] > <javascript:_e(%7B%7D,'cvml','[email protected]');>. > Visit this group at https://groups.google.com/group/sage-nt. > For more options, visit https://groups.google.com/d/optout. > -- Sent from my massive iPhone 6 plus. -- You received this message because you are subscribed to the Google Groups "sage-nt" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send an email to [email protected]. Visit this group at https://groups.google.com/group/sage-nt. For more options, visit https://groups.google.com/d/optout.
