Done. IO've given positive review to these two tickets, as well as to two 
tickets (#21399, #23339) pointed in the Wiki with long-standing needs_review 
status.

HTH,

--
Emmanuel Charpentier

Le vendredi 30 juin 2017 12:07:15 UTC+2, Emmanuel Charpentier a écrit :
>
> I'll try to do that tonight (probably overnight, since I've only a (small) 
> VM to test that on...).
>
> HTH,
>
> --
> Emmanuel Charpentier
>
> Le vendredi 30 juin 2017 10:15:48 UTC+2, Erik Bray a écrit :
>>
>> Any chance someone can give me review on the following tickets: 
>>
>> https://trac.sagemath.org/ticket/21233 
>> https://trac.sagemath.org/ticket/23097 
>>
>> ? 
>>
>> The first fixes the one consistently failing test on Cygwin.  Florent 
>> reviewed it once a long time ago and had some comments, but I believe 
>> I've addressed his comments (I could be wrong there but I think the 
>> code is fine as is). 
>>
>> The second fixes a bug that doesn't show up in any tests, but can 
>> still lead to severe disk cluttering over time. 
>>
>> Thanks, 
>> Erik 
>>
>> On Thu, Jun 29, 2017 at 11:24 PM, Volker Braun <[email protected]> 
>> wrote: 
>> > As always, you can get the latest beta version from the "develop" git 
>> > branch. Alternatively, the self-contained source tarball is at 
>> > http://www.sagemath.org/download-latest.html 
>> > 
>> > 
>> > 7de256c Updated SageMath version to 8.0.rc0 
>> > 226bb83 Trac #15994: Python 3 preparation: Change for removed members 
>> of 
>> > types module 
>> > 9a0cfac Trac #23294: Do not use modules without cimporting (part 2) 
>> > 439836f Trac #23107: py3: fix everything in src/sage/matrix/* 
>> > f4b8a94 Trac #22297: py3 remove __cmp__ from Element 
>> > 8abee3a Trac #19573: Natural coercion from Integers(p*k) to GF(p) for 
>> prime 
>> > p 
>> > f1c959d Trac #17039: Allow IndexedGenerators to handle `names` 
>> > 5928a38 Trac #23208: Enhanced backtrace on test timeout 
>> > 64ec36c Trac #23290: Graph.merge_vertices() destroys loops 
>> > 0fcfddc Trac #22777: Animate in Jupyter notebook 
>> > 99ac16f Trac #23289: polymake does not build with gcc.7.1 
>> > ede52b6 Trac #23308: Remove unused variable from RealNumber object 
>> > 273a2af Trac #23306: Do not change Singular includes 
>> > 34ea4af Trac #22277: change ring multivariate Laurent Polynomials 
>> > 5a4cbef Trac #23323: use string types in Cartan factory 
>> > 5fe4415 Trac #23317: NULL result without error while sorting words 
>> > 52fb56e Trac #23314: Ignored exceptions in glpk_backend.pyx 
>> > e7ea799 Trac #23305: py3: work on cmp in fraction fields and orders in 
>> > number fields 
>> > e661e6c Trac #23303: py3: get rid of cmp for species and yang-baxter 
>> > 5392dd6 Trac #23302: Fix pickling of UniqueFactory elements with Cython 
>> 0.26 
>> > a467d23 Trac #23301: py3: some care for cmp in some modular files 
>> > ced02e9 Trac #23262: Enable png support in giac 
>> > 31268b9 Trac #23248: sympy behavior depends on gmpy2 installation 
>> > fa8cb83 Trac #23226: py3: some care for cmp in schemes 
>> > f58d4e8 Trac #23159: Deprecation from #5930 should not use inspect 
>> > 82df171 Trac #23093: Doctest fixes for bugs with real_part and is_real 
>> > 1e5f842 Trac #23067: Upgrade R to 3.4.0 
>> > 8236443 Trac #18700: Use GroupAlgebra as the standard class for group 
>> > algebras 
>> > 005c29b Trac #17554: Univariate Laurent polynomial do not properly 
>> handle 
>> > __call__ 
>> > ce5653b Trac #16516: Faster roots computation for sparse polynomials 
>> over ZZ 
>> > ec4b5bb Trac #15484: Implement Yangian for gl(n) 
>> > 56d1543 Trac #19974: document "sage --notebook=jupyter" 
>> > afeb0d6 Updated SageMath version to 8.0.beta12 
>> > 
>> > -- 
>> > You received this message because you are subscribed to the Google 
>> Groups 
>> > "sage-release" group. 
>> > To unsubscribe from this group and stop receiving emails from it, send 
>> an 
>> > email to [email protected]. 
>> > To post to this group, send email to [email protected]. 
>> > Visit this group at https://groups.google.com/group/sage-release. 
>> > For more options, visit https://groups.google.com/d/optout. 
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-release" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-release.
For more options, visit https://groups.google.com/d/optout.

Reply via email to