On 16 May 2018 at 12:06, Samuel Lelièvre <samuel.lelie...@gmail.com> wrote:
> Would changing the doctest from > > sage: pol.roots(multiplicities=False, proof=False) > > to > > sage: sorted(pol.roots(multiplicities=False, proof=False)) > > solve this? > I think that in other places where roots are returned, the functino which computes the roots does the sorting, so then it is not neccessary to use sorted() in the doctest; this also has the advantage that if the root-finding algorithm changes, that output does not change even when the roots are now found in a different order. > > 2018-05-16 10:16 GMT+02:00 Dima Pasechnik <dimp...@gmail.com>: > >> in this case doctest basically compares strings, >> obtained from the list of roots. >> Order of the latter is not important. >> By right, one should compare sets, not lists. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-release" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sage-release+unsubscr...@googlegroups.com. >> To post to this group, send email to sage-release@googlegroups.com. >> Visit this group at https://groups.google.com/group/sage-release. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "sage-release" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-release+unsubscr...@googlegroups.com. > To post to this group, send email to sage-release@googlegroups.com. > Visit this group at https://groups.google.com/group/sage-release. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sage-release" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-release+unsubscr...@googlegroups.com. To post to this group, send email to sage-release@googlegroups.com. Visit this group at https://groups.google.com/group/sage-release. For more options, visit https://groups.google.com/d/optout.
