That statement is actually false.  I think this issue needs to be 
addressed.  I think the old venvs should be removed when doing an 
incremental build, since I cannot think of any use for them.

Here is the problem.  When I did an incremental build with the 
venv-python3.10.3 in place, a new venv named python3.10.5 was created.  But 
that new venv depends on the old 3.10.3 venv.  In fact, there are at least 
16 executable files in sage/venv-python3.10.5/bin for which the shebang 
points to
    sage/venv-python3.10.3/bin/python3
This prevents sage from working after the 3.10.3 venv is removed.  There 
may be other dependencies between the two venvs as well.

It seems like bad practice to create a venv which depends on another venv.  
That defeats the purpose of a venv.  Also it does not make sense to me for 
incremental builds to cause the sage directory to contain an ever-expanding 
set of virtual envs each of which depends on the previous one.

I am guessing that these bad shebangs are created because the old venv is 
actually being used to build the new venv. 

Here is a list of the files with bad shebangs in sage/venv-python3.10.5/bin
math-readline
sage-cleaner
sage-coverage
sage-cython
sage-eval
sage-fixdoctests
sage-ipython
sage-list-packages
sage-notebook
sage-num-threads.py
sage-preparse
sage-run
sage-run-cython
sage-runtests
sage-startuptime.py
sage-venv-config

- Marc





On Wednesday, July 13, 2022 at 4:55:02 PM UTC-5 [email protected] wrote:

> Yes, you can delete the old venv. We do not uninstall other venvs that may 
> have been built previously. 
>
> On Wednesday, July 13, 2022 at 1:08:57 PM UTC-7 [email protected] wrote:
>
>> After working around the issues with the bootstrap script and 
>> symengine_py I have managed to build 9.7.beta5 on an arm mac mini.  This 
>> was an incremental build from beta4.  When the build finished I noticed 
>> that both sage/local/var/lib/sage/venv-python3.10.3 and 
>> sage/local/var/lib/sage/venv-python3.10.5 existed.  The 3.10.3 venv cannot 
>> be required, because it never gets created if make distclean is run first.  
>> So it seems to be doing nothing but wasting disk space.  Shouldn't it get 
>> removed once the build finishes?
>>
>> - Marc
>>
>> On Sunday, July 10, 2022 at 6:24:36 PM UTC-5 Volker Braun wrote:
>>
>>> As always, you can get the latest beta version from the "develop" git 
>>> branch. Alternatively, the self-contained source tarball is at 
>>> http://www.sagemath.org/download-latest.html
>>>
>>> 625ac58151 (trac/develop, tag: 9.7.beta5) Updated SageMath version to 
>>> 9.7.beta5
>>> 413ff13c54 Trac #34056: cleaning two files in quadratic forms
>>> cb65d06dd2 Trac #34055: Remove "ssl" target from Makefile
>>> 0740d209ca Trac #34053: pycodestyle cleanup in 
>>> src/sage/graphs/base/static_sparse_graph.pyx
>>> 539a5c073c Trac #34046: pycodestyle cleanup in 
>>> src/sage/graphs/base/boost_graph.pyx
>>> 6790b30aeb Trac #34044: pycodestyle cleanup in 
>>> src/sage/graphs/generators/smallgraphs.py (part 3)
>>> 6e4de5191b Trac #34043: pycodestyle cleanup in 
>>> src/sage/graphs/generators/smallgraphs.py (part 2)
>>> 3d2f91c326 Trac #34042: pycodestyle cleanup in 
>>> src/sage/graphs/generators/smallgraphs.py (part 1)
>>> 45c1d36c3a Trac #34034: pycodestyle cleanup in 
>>> src/sage/graphs/generators/random.py
>>> 9f1388bac5 Trac #34032: pycodestyle cleanup in 
>>> src/sage/graphs/generators/world_map.py
>>> 248a6e15e6 Trac #34023: pycodestyle cleanup in distance_regular.pyx 
>>> (part 1)
>>> 0a77b4496f Trac #34022: pycodestyle cleanup in 
>>> src/sage/graphs/generators/classical_geometries.py
>>> 0cec8684d7 Trac #34135: modernize super() in groups
>>> 38b2bf7529 Trac #34058: sage 9.6 special function translation issue with 
>>> fricas. elliptic_ec
>>> 720adde3bb Trac #32716: pkgs/sagemath-*/tox.ini: Create environment that 
>>> uses Sage's python as the basepython, fix sagemath-standard deps
>>> 6294f36ee4 Trac #28925: Modify find_python_sources to support 
>>> modularization of sagelib by native namespace packages (PEP 420)
>>> 5063ca7441 Trac #34021: pycodestyle in 5 files of 
>>> src/sage/graphs/generators
>>> 648ea02cda Trac #34018: pycodestyle cleanup in 
>>> src/sage/graphs/graph_decompositions/
>>> 44562ec0cf Trac #34016: improve pycodestyle in 4 files in graphs
>>> aa79451a04 Trac #34015: pycodestyle cleanup in planarity.pyx and 
>>> path_enumeration.pyx
>>> 3268d19fa5 Trac #34013: pycodestyle cleanup in schnyder.py and 
>>> print_graphs.py
>>> a6f5a56109 Trac #34012: pycodestyle cleanup in 
>>> sage.graphs.spanning_tree.pyx, weakly_chordal.pyx
>>> b5041b18ad Trac #34011: pycodestyle cleanup in sage.graphs.views.pyx, 
>>> trees.pyx, traversals.pyx
>>> 81f843e76b Trac #34010: pycodestyle cleanup in 
>>> sage.graphs.tutte_polynomial.py
>>> c2550f7093 Trac #34009: pycodestyle cleanup in 
>>> sage.graphs.hyperbolicity.pyx
>>> 44a5f5b3d9 Trac #33952: Add methods to compute holomorphic differentials 
>>> of function field
>>> 6ea1dc5f9e Trac #33868: Add modules over integral domain
>>> b593b48ed7 Trac #33791: ci-cygwin: Refactor using reusable workflows
>>> 1fc79b83f6 Trac #33788: GH Actions: Split ci-macos.yml out from tox.yml
>>> 931d6ac039 Trac #33777: Deprecate Sage's CHomP interface
>>> c364788de0 Trac #33708: make elliptic-curve isogenies compute Montgomery 
>>> codomains
>>> 64e29cf9d9 Trac #33144: Remove some py2 tags in explain_pickle
>>> 1c0f22aabf Trac #34132: Update primesieve to 8.0, primecount to 7.4
>>> 9793520438 <(979)%20352-0438> Trac #34121: Heegner point method can 
>>> return a point defined over the wrong field
>>> 3208d2c51f Trac #34112: some details in L-functions
>>> 65722f53c1 Trac #34111: 'PosixPath' object has no attribute 
>>> '_libgap_init_'
>>> d860f2e146 Trac #34098: Installation manual: Improvements for homebrew, 
>>> conda
>>> afb3761f26 Trac #34090: Update python3 to 3.10.5
>>> f56dc7b1f3 Trac #34085: fix some details in braid groups
>>> b1a00624dc Trac #34082: Add an option up_to_isomorphism for is_subgraph
>>> 8c5d4ca3a4 Trac #34080: pycodestyle cleanup in src/sage/graphs/digraph.py
>>> 7ad1358ac7 Trac #34062: enhance our conversion system
>>> 9c530f7a59 Trac #34061: fix pyflakes warnings in src/sage/misc/cython.py
>>> b221b0d7e1 Trac #34060: Height function for polynomials on number fields
>>> 57ec521c2a Trac #34052: tweaking the giac / libgiac interface
>>> 99fba2a5de Trac #34051: Update FriCAS to 1.3.8
>>> 0de1a2c955 Trac #34049: fix wrong use of Path inside libgap.Read
>>> 9d189b384a Trac #34045: OpenSSL 3.0.4 security update
>>> f0e2346cbf Trac #34041: improve and document GAP and libgap memory 
>>> customisation
>>> 59188e4443 Trac #34040: fix W605 in all pyx files inside matrix/
>>> ac0188973e Trac #34039: fix pycodestyle E306 in categories and part of 
>>> combinat
>>> 890daa517b Trac #34029: bug in elliptic curve saturation: update to 
>>> eclib bugfix release 20220621 required.
>>> add158fc01 Trac #34006: Fix the Killing form and generators for a Lie 
>>> subalgebra
>>> 4064ea2cf4 Trac #34004: Inconsistent behaviour for 
>>> subgraph_search_iterator
>>> a9270ab20c Trac #33995: make *test*: Log to a common log file test.log
>>> 02e1c3b5e1 Trac #33928: phitigra error with hold_canvas
>>> 5bc07720dd Trac #33898: Update texttable to 1.6.4, fix spkg-check
>>> 0d76aee2b1 Trac #33873: Refactor system package scripts
>>> 6455b21183 Trac #33854: Generalized Sierpinski graphs generator
>>> 670fb54de8 Trac #33849: FAQ, Developer's guide: Update documentation of 
>>> the release process
>>> 042e07e7dc Trac #33800: cibuildwheel workflow for sagemath-objects, 
>>> sagemath-categories
>>> f513e8f588 Trac #33795: Move handling of "sage --docbuild" back to 
>>> src/bin/sage
>>> 63f461cdbe Trac #33789: sage-dist-helpers (sdh_pip_install): Change 
>>> default to --build-isolation
>>> 80d2ee6704 Trac #33295: Refactor sage_conf
>>> 662aaf256a Trac #32423: Update numpy to 1.22.x, scipy 1.8.x, networkx 
>>> 2.8.x
>>> d98aa7304d Trac #29549: bootstrap: Clean up use of gettextize
>>> 24b4eeba5e Trac #13321: FreeModule.hom stores its matrix over the wrong 
>>> ring
>>> 93357f31bf Trac #34104: Build & Test workflow: Run apt-get update first
>>> 23e4bbe7d5 Trac #34092: Docbuild workflow broken because furo is too new
>>> 9440e71d60 Trac #34088: cygwin python3 missing ensurepip
>>> 9879ff4e0c Trac #33936: Remove runtime dependency on sage_docbuild 
>>> introduced in #33763
>>> 55d05c97cb Trac #31403: giac: Make cliquer a dependency, libnauty an 
>>> optional dependency
>>> 843eb03e7e (tag: 9.7.beta4) Updated SageMath version to 9.7.beta4
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-release" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-release/610271c3-a899-4cc4-b0f5-e52b7602a1ccn%40googlegroups.com.

Reply via email to