On Sunday, May 21, 2023 at 5:44:35 AM UTC-7 Samuel Lelievre wrote: 2023-05-21 01:00 UTC, Matthias Köppe: > > I have created a changelog at > https://github.com/sagemath/sage/releases/tag/10.0 > (automatically generated from the merged PRs by GitHub; > then lightly edited).
Thanks. > Some notes: > > - The list of "New Contributors" was also automatically generated > by GitHub. It did not know the contributors of previous versions. > I've manually removed many of these lines when I recognized > the username. There may be others that should be removed > from this list; let me know. Here is one way to detect a few. By hovering over the github handles in the "new contributors" list at - https://github.com/sagemath/sage/releases/tag/10.0 one can get (or guess) some names: - @Sandstorm831: Rohan Garg - @MatteoCati: Matteo Cati - @zovelsanj: Sanjay Rijal - @kryzar: Antoine Leudière - @minaminao: minaminao - @jnash10: Agamdeep Singh - @thecaligarmo: Aram Dermenjian - @wermos: Tirthamkar Mazumder - @prirai: Priyanshu Kumar Rai - @mathcals: Sander - @remyoudompheng: Rémy Oudompheng - @Eloitor: Eloi Torrents - @MatanZ: Matan Ziv-Av - @karan0handa: Karan Handa - @yukibl: Yuki - @alexhutman: Alex Hutman - @aadya940: Aadya Chinubhai - @fingolfin: Max Horn - @marizee: Marie Bonboire Then, grepping the past changelogs reveals a few previous contributions: ```shell $ git clone https://github.com/sagemath/website.git sagemath-website $ cd sagemath-website/src/changelogs $ grep -i "Matteo Cati" *.txt sage-9.8.txt: - Matteo Cati [first contribution] $ grep -i "Antoine Leudière" *.txt sage-9.7.txt: - Antoine Leudière [first contribution] $ grep -i "Aram Dermenjian" *.txt sage-6.9.txt: - Aram Dermenjian [first contribution] $ grep -i "Rémy Oudompheng" *.txt sage-9.7.txt: - Rémy Oudompheng [first contribution] $ grep -i "Max Horn" *.txt sage-9.4.txt: - Max Horn [first contribution] Thanks for working on this. I've removed these 5 from the "New contributors" list. Besides, some users might have had a Sage Trac username similar to their github handle, or have used github authentication to contribute to Sage Trac, so it would be nice to be able to search Trac, if it was restored (even readonly). We have been very careful about preserving ALL information from Trac. A lot of thought and hard work has gone into this. Specifically, all username mappings were migrated to https://www.sagemath.org/development-map.html > - We do not have clean Author/Reviewer information > on all of our PRs. The changelog only shows > the GitHub handle of the user who created the PR. This is a sad loss of the new system. Also on Trac the Author/Reviewer information was not automagically created. The authors and reviewers had to manually put their names in the corresponding fields. We just need to build this into our new workflow. For example, in the PR template we could include something like "Authors (if not the same as the PR author): ......." For instance, #35571 is authored by Thierry Monteil, and reviewed by Matthias Köppe, even though the PR was created by Dima Pasechnik. Thanks, I've updated the release notes accordingly. -- You received this message because you are subscribed to the Google Groups "sage-release" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-release+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-release/772997d4-1934-4405-bb1d-ef2a88f83b46n%40googlegroups.com.
