On Mar 6, 10:48 am, Kelvin Li <[email protected]> wrote:
> (By the way, if someone could help me figure out why the patchbot is
> encountering a doctest failure on that patch, I'd very much appreciate
> it!)
That's because the doctest the patchbot complains about is indeed
failing. Stick a line
print "modified_attached_files got called; returning:",modified_files
right before the return statement in modified_attached_files to find
out why. Also, your rewrite of the routine changes its implementation
from a generator to just a list, but the comment in the original
version reasons why the delayed execution of a generator is really
intended there. You might want to stick a little closer to the
original to begin with and only make small changes, at each step
checking that you haven't broken anything.
I have to say I'm a little bit puzzled why the original doctest
succeeded: by the time the call to "modified_attached_files" is made,
the file should have been reloaded already and hence not be reported
as "modified" anymore. The way to check this would be to do it all on
one line, so that the preparser cannot intervene, i.e.,
sage: f=open(t,'w'); f.write("a = 10"); f.close();
modified_attached_files()
['/...py']
--
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-support
URL: http://www.sagemath.org
