#4155: [with patch, needs review] Speed up totally real field enumeration code
---------------------------+------------------------------------------------
Reporter: craigcitro | Owner: craigcitro
Type: defect | Status: assigned
Priority: major | Milestone: sage-3.1.3
Component: number theory | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Comment (by mabshoff):
The patch that Craig posted applies cleanly against 3.1.2 as well as my
current 3.1.3.alpha1 merge tree:
{{{
[EMAIL PROTECTED]:/scratch/mabshoff/release-
cycle/sage-3.1.3.alpha1/devel/sage$ patch -p1 --dry-run < trac-4155.patch
patching file sage/libs/pari/gen.pxd
patching file sage/libs/pari/gen.pyx
Hunk #1 succeeded at 4933 (offset 23 lines).
Hunk #2 succeeded at 6448 (offset 70 lines).
patching file sage/rings/number_field/totallyreal.py
patching file sage/rings/number_field/totallyreal.pyx
patching file sage/rings/number_field/totallyreal_data.pxd
patching file sage/rings/number_field/totallyreal_data.pyx
patching file sage/rings/number_field/totallyreal_rel.py
patching file setup.py
Hunk #1 succeeded at 955 (offset 12 lines).
[EMAIL PROTECTED]:/scratch/mabshoff/release-cycle/sage-3.1.2/devel/sage$ patch
-p1 --dry-run < trac-4155.patch
patching file sage/libs/pari/gen.pxd
patching file sage/libs/pari/gen.pyx
Hunk #1 succeeded at 4933 (offset 23 lines).
Hunk #2 succeeded at 6448 (offset 70 lines).
patching file sage/rings/number_field/totallyreal.py
patching file sage/rings/number_field/totallyreal.pyx
patching file sage/rings/number_field/totallyreal_data.pxd
patching file sage/rings/number_field/totallyreal_data.pyx
patching file sage/rings/number_field/totallyreal_rel.py
patching file setup.py
Hunk #1 succeeded at 954 (offset 11 lines).
}}}
Doctests for 3.1.2+Craig's patch pass. I assume they also do against the
current 3.1.3.alpha1 merge tree.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4155#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
