#3943: [with patch, almost positive review] block designs patch
---------------------------+------------------------------------------------
Reporter: wdj | Owner: wdj
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.1.3
Component: combinatorics | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Changes (by rlm):
* summary: [with patch, needs work] block designs patch => [with patch,
almost positive review] block designs patch
Comment:
1. These need to be fixed:
{{{
SCORE devel/sage/sage/combinat/designs//incidence_structures.py: 94% (16
of 17)
Missing documentation:
* incidence_matrix(self):
Possibly wrong (function name doesn't occur in doctests):
* block_sizes(self):
}}}
2. Earlier, I made the comment "If you are comparing two lists of ints,
`block_cmp` gives exactly the same output as `cmp`." This hasn't yet been
addressed. I think you can just remove the function and replace calls to
it with just `cmp` and be fine.
3. Like I said before, `BlockDesign` should be a class which inherits from
the Incidence structure class-- not just a function which returns an
incidence structure (e.g. Graph and DiGraph inheriting from GenericGraph
in graph.py). Does `dual_block_design` make sense as a function of just
any incidence structure? If so, maybe it should be called
`dual_incidence_structure`. Either way it should not call BlockDesign
unless it is guaranteed to be one.
Once these three issues are taken care of I am prepared to give the ticket
a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3943#comment:26>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
