#4132: [with patch, needs work] complex arithmetic passes via pari
------------------------------+---------------------------------------------
 Reporter:  robertwb          |        Owner:  AlexGhitza
     Type:  enhancement       |       Status:  assigned  
 Priority:  major             |    Milestone:  sage-3.1.3
Component:  basic arithmetic  |   Resolution:            
 Keywords:                    |  
------------------------------+---------------------------------------------
Changes (by robertwb):

  * summary:  [with patch, needs review] complex arithmetic passes via pari
              => [with patch, needs work] complex arithmetic
              passes via pari

Comment:

 Thanks. For the most part it looks good. Here's some suggestions though:

  * Sqrt(x) for negative x should be pure imaginary, even if a special case
 is needed.
  * Calling {{{a.__invert__()}}} manually is a Python call, use {{{~a}}}
 instead.
  * There seems to be a regression of accuracy in some of these examples.
 And some give totally different answers! Ideally, none of the doctests
 should have to change--and if any of them do there should be an
 explanation as to why the new answer is the correct one (if there are ones
 your not sure on, feel free to ask).
  * some benchmarking would be good, especially for some of the more
 complicated ones like tan, or even sqrt. You ''should'' be faster, but
 it's best to be safe.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4132#comment:6>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to