#4240: [with patch; positive review]  magma -- increase doctest coverage of
magma.py (all exported methods)
-------------------------+--------------------------------------------------
 Reporter:  was          |        Owner:  was       
     Type:  enhancement  |       Status:  assigned  
 Priority:  major        |    Milestone:  sage-3.1.3
Component:  interfaces   |   Resolution:            
 Keywords:               |  
-------------------------+--------------------------------------------------
Changes (by mabshoff):

  * summary:  [with patch; needs work]  magma -- increase doctest coverage
              of magma.py (all exported methods) => [with
              patch; positive review]  magma -- increase
              doctest coverage of magma.py (all exported
              methods)

Comment:

 I fixed all the problems and a trivial reviewer patch is coming up. I did
 delete two hunks from the part3 patch since it contained fixes already
 done independently due to a previous patch. Tests pass with and without
 optional except two failures due to using Magma 2.13 instead of 2.14 on
 the test machine, but I can live with that:
 {{{
 sage -t -long -optional devel/sage/sage/interfaces/magma.py
 **********************************************************************
 File "/scratch/mabshoff/release-cycle/sage-3.1.3.rc0/tmp/magma.py", line
 90:
     sage: print M2
 Expected:
     Space of modular forms on Gamma_1(5) with character $.1, weight 2, and
 dimension 2 over Integer Ring.
 Got:
     Space of modular forms on Gamma_1(5) with character all conjugates of
 [$.1], weight 2, and dimension 2 over Integer Ring.
 **********************************************************************
 File "/scratch/mabshoff/release-cycle/sage-3.1.3.rc0/tmp/magma.py", line
 92:
     sage: print M2.Basis()   # note -- this has been changed to be *wrong*
 as below in Magma 2.14!!
 Expected:
     [
     1 + 10*q^2 + 20*q^3 + 20*q^5 + 60*q^7 + 50*q^8 + 30*q^10 + O(q^12),
     q + q^2 + 2*q^3 + 3*q^4 + 5*q^5 + 2*q^6 + 6*q^7 + 5*q^8 + 7*q^9 +
 5*q^10 + 12*q^11 + O(q^12)
     ]
 Got:
     [
     1 + 10*q^2 + 20*q^3 + 20*q^5 + 60*q^7 + O(q^8),
     q + q^2 + 2*q^3 + 3*q^4 + 5*q^5 + 2*q^6 + 6*q^7 + O(q^8)
     ]
 **********************************************************************
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4240#comment:8>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to