#4287: [with new patch, needs review] improve elliptic curve doctest (part 5)
--------------------------------+-------------------------------------------
Reporter: zimmerma | Owner: was
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.2
Component: algebraic geometry | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Changes (by cremona):
* summary: [with patch, with review, needs work] improve elliptic curve
doctest (part 5) => [with new patch, needs
review] improve elliptic curve doctest (part 5)
Comment:
Replying to [comment:1 cremona]:
> Patch looks good and applies ok. But as Paul says, we need to see why
load(dumps(F))!=F for a formal group F.
>
> I don't know how to fix this.
I didn't know, but now I do. There was nothing wrong with loads() or
dumps() for formal groups, but they were missing a _cmp_ function so the
"==" comparison was not giving the expected answer.
The second patch (modelled on a similar one by robertwb for
ell_tate_curve.py) seems to do the trick. All tests pass in
elliptic_curves.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4287#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
