#4281: [with patch,with positive review] elliptic curve doctest coverage (part
4)
--------------------------------+-------------------------------------------
Reporter: zimmerma | Owner: was
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.2
Component: algebraic geometry | Resolution:
Keywords: |
--------------------------------+-------------------------------------------
Comment (by cremona):
Replying to [comment:8 wuthrich]:
> Strictly speaking there is still something to do. It checks if E and p
are equal. In a perfect implementation this should be an elliptic curve
over a local field and we should check if they are isomorphic over this
field, not over Q.
>
When we have a type to hold elliptic curves over local fields then this
can perhaps be changed. I also did not bother to compare the (possibly)
cached power series which are part of the class's data. As I see it, this
_cmp_ function is only there for technical Pythonic reasons, and serious
mathematical functionality would not be implemented via the == operator.
> But I agree that the patch fixes this by now and the ticket should be
closed.
Good! Thanks.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4281#comment:9>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
