#2103: [with patch, with partial review] equivalence classes of cusps for
congruence subgroups
---------------------------+------------------------------------------------
Reporter: AlexGhitza | Owner: davidloeffler
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.2.1
Component: modular forms | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Changes (by cremona):
* cc: [EMAIL PROTECTED] (added)
* summary: [with patch, needs review] equivalence classes of cusps for
congruence subgroups => [with patch, with
partial review] equivalence classes of cusps
for congruence subgroups
Comment:
{{{
applying /local/jec/2103.patch
patching file sage/modular/congroup.py
Hunk #3 FAILED at 589
1 out of 10 hunks FAILED -- saving rejects to file
sage/modular/congroup.py.rej
abort: patch failed to apply
}}}
Same on both 3.1.4 and 3.2.apha0. David, could you rebase this? Then
I'll review it.
While I'm here: am I right in thinking that there's quite a lot of code
which is just moved from one place to another? (Judging by the amount of
red and blue I see when viewing the patch).
I certainly like the code from looking at it by eye but it needs to be
able to be applied...
My guess is that the code for giving a complete set of cusp
representatives is not very efficient, but I also think it unlikely that
that function would be needed for large N anyway. I never wrote down
explicit representatives even for Gamma_0(N), but think that you should
have all a/d where 0<d|N and a runs through invertible residues mod
gcd(d,N/d) lifted to be coprime to d.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/2103#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
