#2103: [with patch, with positive review, needs quick review of additional
patch]
equivalence classes of cusps for congruence subgroups
---------------------------+------------------------------------------------
Reporter: AlexGhitza | Owner: davidloeffler
Type: enhancement | Status: assigned
Priority: minor | Milestone: sage-3.2.1
Component: modular forms | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Changes (by craigcitro):
* summary: [with patch, with partial review] equivalence classes of
cusps for congruence subgroups => [with patch,
with positive review, needs quick review of
additional patch] equivalence classes of cusps
for congruence subgroups
Comment:
This is an excellent patch.
In addition to adding the requested functionality, this patch performs
some long-needed cleanup to the class hierarchy in `congroup.py`. In
particular, `Gamma0` and `Gamma1` now inherit from `GammaH`, as makes
sense. I should note that it might be a good project for someone to look
at the code in `congroup.py`, and see how much of the code for `Gamma0`
and `Gamma1` could be moved up to/unified with code in `GammaH`.
I've added a small patch to apply on top of `2103-new.patch` which cleans
up a few things. Most of it is documentation touch-ups. I replaced the
`__cmp__` methods for `Gamma0` and `Gamma1` which the original patch
removed, and rewrote them to do comparison without ever generating the
corresponding lists of elements.
Someone should look over my additional patch, but after that, this is
ready to go.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/2103#comment:10>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
