#4433: [with patch, needs work] Replace factorial with a symbolic version
-------------------------+--------------------------------------------------
Reporter: whuss | Owner: whuss
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.2.1
Component: calculus | Resolution:
Keywords: |
-------------------------+--------------------------------------------------
Changes (by mabshoff):
* summary: [with patch, needs review] Replace factorial with a symbolic
version => [with patch, needs work] Replace
factorial with a symbolic version
Comment:
A couple remarks:
* the first patch removes "!" from the list of tokens which we used to
ignore up to now. Now it changes meaning to be factorial, but I am not so
sure it is a good idea since we use to explicitly forbid it. I don't know
the reason why we did that, so see my comment below.
* the second patch removes fact() [nee factorial_numeric()] from
arith.py, but policy is to deprecate removed functions, especially
something as simple and long existing like fact() in that file cannot be
just removed. See "def dynkin_diagram(t)" in
combinat/root_system/dynkin_diagram.py for an good example on how to use
deprecation in Sage.
Especially the "!" change should be discussed on [sage-devel] since that
is a rather fundamental change. I also cannot find a single occurrence of
"!" in the docstring or tests, but maybe I overlooked something. *If* the
patch is merged with the "!" change it needs to be doctests.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4433#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
