#4249: [with patch, with positive review] Inconsistency in number field integral
bases
---------------------------+------------------------------------------------
Reporter: cremona | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.2.1
Component: number theory | Resolution:
Keywords: number fields |
---------------------------+------------------------------------------------
Changes (by craigcitro):
* summary: [with patch] Inconsistency in number field integral bases =>
[with patch, with positive review]
Inconsistency in number field integral bases
Comment:
This looks good!
The only complaints I had were one or two naming issues; in particular, I
didn't see why `integral_basis_internal` should be visible when you tab
complete. (The `internal` in the name really makes it seem weird.) So I've
just corrected a few naming issues, and made a new patch. Then I rebased
the patch John Voight and I wrote on top of this. So you should apply:
{{{
sage-4249.patch
trac-4249-1a.patch
trac-4249-pt2a.patch
}}}
in order. (I've deleted the old pt2 patch, just to help avoid confusion.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4249#comment:18>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
