#4519: [with patch, positive review] problem with build code
------------------------+---------------------------------------------------
Reporter: craigcitro | Owner: craigcitro
Type: defect | Status: new
Priority: major | Milestone: sage-3.2
Component: build | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Changes (by GeorgSWeber):
* priority: blocker => major
* summary: [with patch, needs review] problem with build code => [with
patch, positive review] problem with build code
Comment:
Hmmm,[[BR]]
it seems to me that somewhere I have read that only the lowest 8 bit of
"such" return values would be taken into account. I don't remember a
reference however, or in what precise context --- bash? posix? ...[[BR]]
But that "256" suddenly becomes "0" would support this faint memory of
mine.
Be it as it be, I just tested (with 3.2.rc0) that this patch does indeed
fix the problem described (which is there without the patch); and the
nature of the patch is local enough one can be pretty sure that nothing
else does break.
Positive review from my side.
The only thing I don't agree with is the original classification as
"blocker" --- nothing really bad happens, because the old "gen.so" or
"gen.dylib" or whatever compiled python extension from the last successful
run is still there, and accessed by the wrongly started Sage session. And
the error message is displayed prominently enough.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4519#comment:1>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
