#4601: [with patch; positive review] optional magma interface -- fix all broken
optional doctests by introducing _magma_init_(self, magma) signature
------------------------+---------------------------------------------------
Reporter: was | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.2.1
Component: interfaces | Resolution:
Keywords: |
------------------------+---------------------------------------------------
Changes (by mabshoff):
* summary: [with patch; needs review] optional magma interface -- fix
all broken optional doctests by introducing
_magma_init_(self, magma) signature => [with
patch; positive review] optional magma
interface -- fix all broken optional doctests
by introducing _magma_init_(self, magma)
signature
Comment:
There is one slight problem here with the doctests:
{{{
sage -t -long devel/sage/sage/interfaces/magma.py
**********************************************************************
File "/scratch/mabshoff/release-
cycle/sage-3.2.1.alpha1/devel/sage/sage/interfaces/magma.py", line 1559:
sage: magma(S.gen_names()[1])
Exception raised:
Traceback (most recent call last):
File "/scratch/mabshoff/release-
cycle/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1231, in
run_one_test
self.run_one_example(test, example, filename, compileflags)
File "/scratch/mabshoff/release-
cycle/sage-3.2.1.alpha1/local/bin/sagedoctest.py", line 38, in
run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File "/scratch/mabshoff/release-
cycle/sage-3.2.1.alpha1/local/bin/ncadoctest.py", line 1172, in
run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_52[3]>", line 1, in <module>
magma(S.gen_names()[Integer(1)])###line 1559:
sage: magma(S.gen_names()[1])
NameError: name 'S' is not defined
**********************************************************************
}}}
But that is obviously easy to fix :)
I have read the patch and while it wouldn't hurt that mhansen for example
would take another look everything looks peachy :)
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4601#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
