#4620: [with patch, needs review] setup.py: if the cythonization fails then next
"sage -b" starts to build extensions
----------------------+-----------------------------------------------------
 Reporter:  mabshoff  |        Owner:  craigcitro
     Type:  defect    |       Status:  assigned  
 Priority:  blocker   |    Milestone:  sage-3.2.1
Component:  build     |   Resolution:            
 Keywords:            |  
----------------------+-----------------------------------------------------
Changes (by craigcitro):

  * status:  new => assigned
  * summary:  setup.py: if the cythonization fails then next "sage -b"
              starts to build extensions => [with patch,
              needs review] setup.py: if the cythonization
              fails then next "sage -b" starts to build
              extensions

Comment:

 The attached patch fixes the issue. The problem was that we were copying
 the files at one point in the code, and then running Cython later. Of
 course, if Cython failed, the code was still copied, which meant it would
 pass a timestamp comparison on later builds. The patch fixes this by only
 copying once the file is successfully built.

 In addition, it slightly expands the capabilities of William's parallel
 build code: now, in addition to accepting strings, it accepts pairs of the
 form `[f, v]`, and calls `f(v)`. The previous code did this with `f`
 always being `run_command`.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4620#comment:1>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to