#4313: [with patch, needs work (doctests!)] Add some functionality to matrices
in
eclib
-----------------------------------------+----------------------------------
Reporter: cremona | Owner: was
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.2.1
Component: interfaces | Resolution:
Keywords: eclib CremonaModularSymbols |
-----------------------------------------+----------------------------------
Changes (by craigcitro):
* summary: [with patch, needs review] Add some functionality to matrices
in eclib => [with patch, needs work
(doctests!)] Add some functionality to matrices
in eclib
Old description:
> The attached patch (based on 3.1.4) makes two changes in
> libs/cremona/mat*:
> 1. Adds getitem methods to the matric class so i,j entries may be
> extracted;
> 2. Changes the conversion to sage of matrices so that matrices over
> ZZ are constructed instead of ZZ.
>
> These were done as part of a hands-on tutorial William gave to John in
> Bordeaux.
New description:
The attached patch (based on 3.1.4) makes two changes in
libs/cremona/mat*:
1. Adds getitem methods to the matric class so i,j entries may be
extracted;
2. Changes the conversion to sage of matrices so that matrices over ZZ
are constructed instead of QQ.
These were done as part of a hands-on tutorial William gave to John in
Bordeaux.
Comment:
Code looks good. Only thing needed are some doctests on `__getitem__` in
`mat.pyx` -- it would be nice to see a few doctests there, especially ones
written to test weird corner cases.
(Also edited a typo in the description for this ticket.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4313#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
