#4308: [with spkg, needs work] make mpc an optional spkg
-------------------------------+--------------------------------------------
Reporter: thevenyp | Owner: mabshoff
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.2.1
Component: optional packages | Resolution:
Keywords: |
-------------------------------+--------------------------------------------
Changes (by was):
* summary: [with spkg, needs review] make mpc an optional spkg => [with
spkg, needs work] make mpc an optional spkg
Comment:
REFEREE REPORT:
1. There is no .hg repository in the spkg. You need to
{{{
$cd mpc-0.5
$ hg init
$ hg add spkg-install spkg-check SPKG.txt
}}}
2. The SPKG.txt doesn't list anybody or any contact info under "package
maintainer".
3. The SPKG.txt has an empty changelog. This should at least list exactly
which version of upstream is in the src subdirectory. Typically when
refereeing a patch, I like to verify that src/ contains the claimed
upstream exactly, since I don't want some virus crap sneaking in.
4. Speaking of crap, the src/src/ subdirectory is full of .o pre-compiled
binary object files. These need to all be deleted.
{{{
teragon-2:src wstein$ pwd
/Users/wstein/tmp/mpc-0.5/src/src
teragon-2:src wstein$ ls -1 *.o |wc -l
57
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4308#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
