#4636: [with patch, needs work] improve
polynomial_modn_dense_ntl.Polynomial_dense_mod_p
---------------------------------------------+------------------------------
Reporter: ncalexan | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.2.1
Component: number theory | Resolution:
Keywords: polynomial modn finite field gf |
---------------------------------------------+------------------------------
Changes (by was):
* summary: [with patch, needs review] improve
polynomial_modn_dense_ntl.Polynomial_dense_mod_p
=> [with patch, needs work] improve
polynomial_modn_dense_ntl.Polynomial_dense_mod_p
Comment:
REFEREE REPORT:
I applied this patch and doctested the rings directory. I get a couple of
doctest failures:
{{{
sage -t devel/sage-main/sage/rings/integer_mod.pyx
**********************************************************************
File "/Users/wstein/sage/devel/sage-main/sage/rings/integer_mod.pyx", line
505:
sage: type(a.polynomial())
Expected:
<type
'sage.rings.polynomial.polynomial_modn_dense_ntl.Polynomial_dense_mod_p'>
Got:
<type
'sage.rings.polynomial.polynomial_modn_dense_ntl.Polynomial_dense_modp_ntl_zz'>
**********************************************************************
sage -t devel/sage-main/sage/rings/finite_field_givaro.pyx
**********************************************************************
File "/Users/wstein/sage/devel/sage-
main/sage/rings/finite_field_givaro.pyx", line 1799:
sage: type(f)
Expected:
<type
'sage.rings.polynomial.polynomial_modn_dense_ntl.Polynomial_dense_mod_p'>
Got:
<type
'sage.rings.polynomial.polynomial_modn_dense_ntl.Polynomial_dense_modp_ntl_zz'>
**********************************************************************
1 items had failures:
sage -t devel/sage-main/sage/rings/finite_field.py
**********************************************************************
File "/Users/wstein/sage/devel/sage-main/sage/rings/finite_field.py", line
178:
sage: type(f)
Expected:
<type
'sage.rings.polynomial.polynomial_modn_dense_ntl.Polynomial_dense_mod_p'>
Got:
<type
'sage.rings.polynomial.polynomial_modn_dense_ntl.Polynomial_dense_modp_ntl_zz'>
**********************************************************************
1 items had failures:
...
sage -t devel/sage-
main/sage/rings/polynomial/multi_polynomial_libsingular.pyx # 1 doctests
failed
sage -t devel/sage-main/sage/rings/integer_mod.pyx # 1 doctests
failed
sage -t devel/sage-main/sage/rings/finite_field_givaro.pyx # 1
doctests failed
sage -t devel/sage-main/sage/rings/finite_field.py # 1 doctests
failed
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4636#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
