#4254: [with patch, needs work] mq.SR improvements for convenience
--------------------+-------------------------------------------------------
Reporter: malb | Owner: malb
Type: defect | Status: new
Priority: major | Milestone: sage-3.2.2
Component: misc | Resolution:
Keywords: |
--------------------+-------------------------------------------------------
Changes (by was):
* summary: [with patch, needs review] mq.SR improvements for
convenience => [with patch, needs work] mq.SR
improvements for convenience
Comment:
REFEREE REPORT:
I tried to figure out how to apply the above patches in their confusing
order, but I guess I failed or something. See below (last patch fails to
apply). Please clarify, and I'll referee this:
{{{
[EMAIL PROTECTED]:~/build/sage-3.2.1.alpha1$ ./sage
----------------------------------------------------------------------
| Sage Version 3.2.1.alpha1, Release Date: 2008-11-26 |
| Type notebook() for the GUI, and license() for information. |
----------------------------------------------------------------------
hgsage:
hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_convenience.patch')
Attempting to load remote file:
http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_convenience.patch?format=raw
Loading: [.]
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg import
"/home/was/.sage/temp/sage/15295/tmp_0.patch"
applying /home/was/.sage/temp/sage/15295/tmp_0.patch
sage:
hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_parameters.patch')
Attempting to load remote file:
http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_parameters.patch?format=raw
Loading: [.]
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg import
"/home/was/.sage/temp/sage/15295/tmp_1.patch"
applying /home/was/.sage/temp/sage/15295/tmp_1.patch
sage:
hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_parameters.2.patch')
Attempting to load remote file:
http://trac.sagemath.org/sage_trac/attachment/ticket/4254/sr_parameters.2.patch?format=raw
Loading: [.]
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status
cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg import
"/home/was/.sage/temp/sage/15295/tmp_2.patch"
applying /home/was/.sage/temp/sage/15295/tmp_2.patch
patching file sage/crypto/mq/sr.py
Hunk #2 FAILED at 288
1 out of 2 hunks FAILED -- saving rejects to file sage/crypto/mq/sr.py.rej
abort: patch failed to apply
}}}
and
{{{
[EMAIL PROTECTED]:~/build/sage-3.2.1.alpha1$ more
devel/sage/sage/crypto/mq/sr.py.rej
--- sr.py
+++ sr.py
@@ -284,8 +289,20 @@
polybori = self._polybori
except AttributeError:
polybori = False
+ kwds.setdefault("polybori", polybori)
- kwds.setdefault("polybori", polybori)
+ try:
+ correct_only = self._correct_only
+ except AttributeError:
+ correct_only = False
+ kwds.setdefault("correct_only", correct_only)
+
+ try:
+ biaffine_only = self._biaffine_only
+ except AttributeError:
+ biaffine_only = False
+ kwds.setdefault("biaffine_only", biaffine_only)
+
return SR(**kwds)
def __getattr__(self, attr):
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4254#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
