#4354: [with patch; needs work] loading a file with spaces in the filename
doesn't
work
--------------------+-------------------------------------------------------
Reporter: anakha | Owner: anakha
Type: defect | Status: new
Priority: major | Milestone: sage-3.2.2
Component: misc | Resolution:
Keywords: |
--------------------+-------------------------------------------------------
Changes (by was):
* summary: [with patch; needs review] loading a file with spaces in the
filename doesn't work => [with patch; needs
work] loading a file with spaces in the
filename doesn't work
Comment:
REFEREE:
Can you please rebase this against 3.2.1.alpha*? I tried applying and got
some many failed hunks I can't go further.
{{{
sage:
hg_scripts.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/4354/trac_4354.patch')
Attempting to load remote file:
http://trac.sagemath.org/sage_trac/attachment/ticket/4354/trac_4354.patch?format=raw
Loading: [..]
cd "/Users/wstein/sage/local/bin" && hg status
cd "/Users/wstein/sage/local/bin" && hg status
cd "/Users/wstein/sage/local/bin" && hg import
"/Users/wstein/.sage/temp/teragon_2.local/1537/tmp_0.patch"
applying /Users/wstein/.sage/temp/teragon_2.local/1537/tmp_0.patch
patching file sage-sage
Hunk #5 succeeded at 227 with fuzz 1 (offset 4 lines).
Hunk #6 succeeded at 246 with fuzz 1 (offset 4 lines).
Hunk #7 FAILED at 332
Hunk #8 FAILED at 376
Hunk #10 succeeded at 474 with fuzz 1 (offset 41 lines).
Hunk #12 succeeded at 507 with fuzz 1 (offset 41 lines).
Hunk #18 succeeded at 603 with fuzz 1 (offset 41 lines).
Hunk #20 succeeded at 647 with fuzz 1 (offset 41 lines).
Hunk #27 FAILED at 768
Hunk #28 FAILED at 794
4 out of 28 hunks FAILED -- saving rejects to file sage-sage.rej
abort: patch failed to apply
}}}
Note -- I did *read* the patch and I think it's very good. Also, I'm very
glad for Mvngu's observations about all those typos, especially line -2 of
SAGE_ROOT/sage. Can you fix those typos in sage too?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4354#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
