#4360: [with patch, needs work] fraction field improvements
------------------------------+---------------------------------------------
 Reporter:  burcin            |        Owner:  burcin    
     Type:  enhancement       |       Status:  assigned  
 Priority:  major             |    Milestone:  sage-3.2.2
Component:  basic arithmetic  |   Resolution:            
 Keywords:                    |  
------------------------------+---------------------------------------------
Changes (by was):

  * summary:  [with patch, needs review] fraction field improvements =>
              [with patch, needs work] fraction field
              improvements

Comment:

 REFEREEING.

 I took sage-3.2.1.rc0 and built it on sage.math and it doctested fine:
 {{{
 All tests passed!
 Total time for all tests: 4285.2 seconds
 }}}

 I applied the above patches (all apply cleanly), rebuilt sage, and two
 doctests fail:
 {{{
         sage -t  devel/sage/sage/structure/sage_object.pyx # 1 doctests
 failed
         sage -t  devel/sage/sage/calculus/desolvers.py # 1 doctests failed
 }}}

 I reran them individually, and both still fail.  Here is what you broke:
 {{{
 sage -t  "devel/sage/sage/calculus/desolvers.py"
 **********************************************************************
 File
 "/home/was/build/sage-3.2.1.rc0/devel/sage/sage/calculus/desolvers.py",
 line 437:
     sage: eulers_method_2x2(f,g, 0, 1, -1, 1/4, 1)
 Expected:
         t                    x                h*f(t,x,y)
 y           h*g(t,x,y)
         0                    1                     -0.25
 -1                 0.50
       1/4                 0.75                     -0.12
 -0.50                 0.29
       1/2                 0.63                    -0.054
 -0.21                 0.19
       3/4                 0.63                   -0.0078
 -0.031                 0.11
         1                 0.63                     0.020
 0.079                0.071
 Got:
              t                    x                h*f(t,x,y)
 y           h*g(t,x,y)
              0                    1                     -0.25
 -1                 0.50
            1/4                 0.75                     -0.12
 -0.50                 0.32
            1/2                 0.63                    -0.046
 -0.18                 0.21
            3/4                 0.63                    0.0040
 0.016                 0.16
              1                 0.69                     0.043
 0.18                 0.15
 **********************************************************************
 1 items had failures:
    1 of  18 in __main__.example_7
 ***Test Failed*** 1 failures.
 For whitespace errors, see the file
 /home/was/build/sage-3.2.1.rc0/tmp/.doctest_desolvers.py
          [9.3 s]
 }}}

 and

 {{{
 sage -t  "devel/sage/sage/structure/sage_object.pyx"

 **********************************************************************
 File
 "/home/was/build/sage-3.2.1.rc0/devel/sage/sage/structure/sage_object.pyx",
 line 744:
     sage: sage.structure.sage_object.unpickle_all(std)
 Expected:
     Successfully unpickled ... objects.
     Failed to unpickle 0 objects.
 Got:
     ** failed:  _class__sage_combinat_sf_llt_LLT_cospin__.sobj
     ** failed:
 _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_s__.sobj
     ** failed:  _class__sage_combinat_sf_jack_JackPolynomials_j__.sobj
     ** failed:  _class__sage_combinat_sf_jack_JackPolynomials_p__.sobj
     ** failed:
 _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_p__.sobj
     ** failed:
 _class__sage_combinat_sf_hall_littlewood_HallLittlewood_q__.sobj
     ** failed:
 _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_q__.sobj
     ** failed:  _class__sage_combinat_sf_llt_LLT_spin__.sobj
     ** failed:
 _class__sage_combinat_sf_hall_littlewood_HallLittlewood_p__.sobj
     ** failed:  _class__sage_combinat_sf_jack_JackPolynomials_q__.sobj
     ** failed:
 _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_h__.sobj
     ** failed:
 _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_ht__.sobj
     ** failed:
 _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_j__.sobj
     ** failed:
 _class__sage_combinat_sf_hall_littlewood_HallLittlewood_qp__.sobj
     Failed:
     _class__sage_combinat_sf_llt_LLT_cospin__.sobj
     _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_s__.sobj
     _class__sage_combinat_sf_jack_JackPolynomials_j__.sobj
     _class__sage_combinat_sf_jack_JackPolynomials_p__.sobj
     _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_p__.sobj
     _class__sage_combinat_sf_hall_littlewood_HallLittlewood_q__.sobj
     _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_q__.sobj
     _class__sage_combinat_sf_llt_LLT_spin__.sobj
     _class__sage_combinat_sf_hall_littlewood_HallLittlewood_p__.sobj
     _class__sage_combinat_sf_jack_JackPolynomials_q__.sobj
     _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_h__.sobj
     _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_ht__.sobj
     _class__sage_combinat_sf_macdonald_MacdonaldPolynomials_j__.sobj
     _class__sage_combinat_sf_hall_littlewood_HallLittlewood_qp__.sobj
     Successfully unpickled 440 objects.
     Failed to unpickle 14 objects.
 **********************************************************************
 1 items had failures:
    1 of   7 in __main__.example_18
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4360#comment:6>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to