#3623: [with patch, needs review] Factory and pickling framework (part of 
coercion
branch)
-------------------------+--------------------------------------------------
 Reporter:  robertwb     |        Owner:  robertwb  
     Type:  enhancement  |       Status:  new       
 Priority:  major        |    Milestone:  sage-3.2.2
Component:  coercion     |   Resolution:            
 Keywords:               |  
-------------------------+--------------------------------------------------
Comment (by mabshoff):

 The patch applies cleanly against 3.2.1 and together with #4276 I am
 seeing two doctest failures:
 {{{
 sage -t -long "devel/sage/sage/structure/coerce.pyx"
 **********************************************************************
 File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/devel/sage/sage/structure/coerce.pyx", line 862:
     sage: V is W
 Expected:
     False
 Got:
     True
 **********************************************************************
 File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/devel/sage/sage/structure/coerce.pyx", line 865:
     sage: cm.coercion_maps(V, W)
 Expected:
     (None,
      Call morphism:
       From: Vector space of dimension 3 over Rational Field
       To:   Vector space of dimension 3 over Rational Field)
 Got:
     (None, None)
 **********************************************************************
 File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/devel/sage/sage/structure/coerce.pyx", line 870:
     sage: cm.coercion_maps(W, V)
 Expected:
     (None,
      Call morphism:
       From: Vector space of dimension 3 over Rational Field
       To:   Vector space of dimension 3 over Rational Field)
 Got:
     (None, Free module morphism defined by the matrix
     [1 0 0]
     [0 1 0]
     [0 0 1]
     Domain: Vector space of dimension 3 over Rational Field
     Codomain: Vector space of dimension 3 over Rational Field)
 **********************************************************************
 1 items had failures:
    3 of  21 in __main__.example_15
 ***Test Failed*** 3 failures.
 }}}
 I guess the first one is worrying while the rest is mostly a printing
 issue.

 The other failure is:
 {{{
 sage -t -long
 "devel/sage/sage/schemes/elliptic_curves/ell_number_field.py"
 **********************************************************************
 File "/scratch/mabshoff/release-
 
cycle/sage-3.2.2.alpha0/devel/sage/sage/schemes/elliptic_curves/ell_number_field.py",
 line 667:
     sage: [E.tamagawa_exponent(P) for P in K(11).support()]
 Exception raised:
     Traceback (most recent call last):
       File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/local/bin/ncadoctest.py", line 1231, in
 run_one_test
         self.run_one_example(test, example, filename, compileflags)
       File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/local/bin/sagedoctest.py", line 38, in
 run_one_example
         OrigDocTestRunner.run_one_example(self, test, example, filename,
 compileflags)
       File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/local/bin/ncadoctest.py", line 1172, in
 run_one_example
         compileflags, 1) in test.globs
       File "<doctest __main__.example_20[7]>", line 1, in <module>
         [E.tamagawa_exponent(P) for P in K(Integer(11)).support()]###line
 667:
     sage: [E.tamagawa_exponent(P) for P in K(11).support()]
       File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-
 packages/sage/schemes/elliptic_curves/ell_number_field.py", line 675, in
 tamagawa_exponent
         return self.local_data(P, proof).tamagawa_exponent()
       File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-
 packages/sage/schemes/elliptic_curves/ell_number_field.py", line 401, in
 local_data
         return self._get_local_data(P,proof)
       File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-
 packages/sage/schemes/elliptic_curves/ell_number_field.py", line 418, in
 _get_local_data
         self._local_data[P] = EllipticCurveLocalData(self, P, proof)
       File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-
 packages/sage/schemes/elliptic_curves/ell_local_data.py", line 140, in
 __init__
         self._Emin, ch, self._val_disc, self._fp, self._KS, self._cp,
 self._split = self._tate(proof)
       File "/scratch/mabshoff/release-
 cycle/sage-3.2.2.alpha0/local/lib/python2.5/site-
 packages/sage/schemes/elliptic_curves/ell_local_data.py", line 528, in
 _tate
         r = -pinv(12*c4) * (c6 + b2 * c4)
       File "element.pyx", line 1074, in
 sage.structure.element.RingElement.__mul__ (sage/structure/element.c:8580)
       File "coerce.pyx", line 697, in
 sage.structure.coerce.CoercionModel_cache_maps.bin_op
 (sage/structure/coerce.c:5808)
     TypeError: unsupported operand parent(s) for '*': 'Maximal Order in
 Number Field in a with defining polynomial x^2 + 11' and 'Number Field in
 a with defining polynomial x^2 + 11'
 **********************************************************************
 }}}

 Cheers,

 Michael

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3623#comment:9>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to