#4693: [with patch, positive review] cleanup work in sage/functions/piecewise.py
----------------------+-----------------------------------------------------
Reporter: mhansen | Owner: wdj
Type: defect | Status: new
Priority: major | Milestone: sage-3.2.2
Component: calculus | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Changes (by wdj):
* summary: [with patch, needs review] cleanup work in
sage/functions/piecewise.py => [with patch,
positive review] cleanup work in
sage/functions/piecewise.py
Comment:
I cannot apply this patch. I've tried various things (adding the 4690
patch first, not adding it, using different Sage releases, ...). As I
said, I read through it and it looks very good. I wanted to read through
the docstring descriptions to see if they still made sense. (For example,
from the diff file, it seemed as though the docstring description for
laplace needed a small rewording.) I also was hoping Mike added himself to
the AUTHOR list at the top of the file. Since the diff doesn't contain
that info and I can't apply the patch, I can't tell.
Still these are very minor issues that can be taken care of later and
should not prevent this from going into Sage. So, I give this a positive
review, pending doctesting. Thanks again, Mike!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4693#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
