#4695: [with patch, needs review] add support for pari's rnfidealdown
-------------------------------------+--------------------------------------
Reporter: ncalexan | Owner: was
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.2.2
Component: number theory | Resolution:
Keywords: relative rnf ideal down |
-------------------------------------+--------------------------------------
Comment (by was):
I read through the code and the only problem I have is that
{{{
def rnfidealdown(self, x):
}}}
has no docstring or doctest, which violates our 100% coverage rule.
Also, a bunch of doctests fail on x86_64 linux (sage.math), and these all
have to get fixed. So once these are fixed and the above function has a
doctest, I'll be happy. The doctest failures (except the segfault) look
like some kind of randomness in the output.
{{{
[EMAIL PROTECTED]:~/build/sage-3.2.1.rc1$ ./sage -tp 12 devel/sage/sage/rings/
Global iterations: 1
File iterations: 1
TeX files: 0
----------------------------------------------------------------------
sage -t devel/sage/sage/rings/padics/padic_field_base_generic.py
[0.1 s]
sage -t devel/sage/sage/rings/padics/lazy_ring_generic.py
[0.1 s]
... passes
sage -t devel/sage/sage/rings/number_field/number_field_ideal_rel.py
**********************************************************************
File "/home/was/build/sage-3.2.1.rc1/devel/sage-
main/sage/rings/number_field/number_field_ideal_rel.py", line 197:
sage: K0.factor(19)
Expected:
(Fractional ideal (-a0 + 1)) * (Fractional ideal (-a0 + 5))
Got:
(Fractional ideal (a0 - 1)) * (Fractional ideal (-a0 + 5))
**********************************************************************
File "/home/was/build/sage-3.2.1.rc1/devel/sage-
main/sage/rings/number_field/number_field_ideal_rel.py", line 200:
sage: P1, w1
Expected:
(Fractional ideal (-a0 + 1), -a0 + 1)
Got:
(Fractional ideal (a0 - 1), a0 - 1)
**********************************************************************
File "/home/was/build/sage-3.2.1.rc1/devel/sage-
main/sage/rings/number_field/number_field_ideal_rel.py", line 216:
sage: K_into_L1(P).ideal_below()
Expected:
Fractional ideal (-a0 + 1)
Got:
Fractional ideal (a0 - 1)
**********************************************************************
1 items had failures:
3 of 36 in __main__.example_6
***Test Failed*** 3 failures.
For whitespace errors, see the file
/home/was/build/sage-3.2.1.rc1/tmp/.doctest_number_field_ideal_rel.py
[3.9 s]
sage -t devel/sage/sage/rings/number_field/number_field.py
**********************************************************************
File "/home/was/build/sage-3.2.1.rc1/devel/sage-
main/sage/rings/number_field/number_field.py", line 4200:
sage: Pp = L1.ideal(K_into_L1(w1)).ideal_below(); Pp
Expected:
Fractional ideal (4*a0 + 1)
Got:
Fractional ideal (5*a0 - 9)
For whitespace errors, see the file
/home/was/build/sage-3.2.1.rc1/tmp/.doctest_number_field.py
------------------------------------------------------------
Unhandled SIGSEGV: A segmentation fault occured in SAGE.
This probably occured because a *compiled* component
of SAGE has a bug in it (typically accessing invalid memory)
or is not properly wrapped with _sig_on, _sig_off.
You might want to run SAGE under gdb with 'sage -gdb' to debug this.
SAGE will now terminate (sorry).
------------------------------------------------------------
A mysterious error (perphaps a memory error?) occurred, which may have
crashed doctest.
[8.0 s]
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4695#comment:1>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
