#3810: [with patch, with positive review (almost)] make abelian group list/iter
and classgroup list/iter more modern
---------------------------+------------------------------------------------
Reporter: ncalexan | Owner: was
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.2.2
Component: number theory | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Changes (by cremona):
* summary: [with patch, needs review] make abelian group list/iter and
classgroup list/iter more modern => [with
patch, with positive review (almost)] make
abelian group list/iter and classgroup
list/iter more modern
Comment:
Just one thing is stopping me giving this the ok:
{{{
sage: G=AbelianGroup([])
sage: G.list()
[]
sage: list(G)
[]
sage: G.order()
1
}}}
Trivial groups do have one element! This special case is handled ok in
the class groups patch, and a similar special case is needed for abelian
groups. (It happens because mrange() delivers nothing at all for an empty
list of lists, that is one valid way of defining a trivial abelian group.)
What's bugging me is that I discovered that same issue with listing
trivial groups myself a few days ago, and somewhere else in trac there's a
patch which does what is needed here -- but I cannot remember which one!
So this might cause some merge problems when my patch goes in.
Apart from this, the second and third patches apply fine to 3.2.1 and
tests pass. *Ignore the first patch which is replaced by the third!*
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3810#comment:9>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
