#4747: [with patch; with positive review] add custom hash function for cusps.
---------------------------+------------------------------------------------
Reporter: was | Owner: was
Type: enhancement | Status: closed
Priority: major | Milestone: sage-3.2.2
Component: number theory | Resolution: fixed
Keywords: |
---------------------------+------------------------------------------------
Comment (by mabshoff):
This patch causes the following doctest failures:
{{{
sage -t -long "devel/sage/sage/modular/congroup.py"
**********************************************************************
File "/scratch/mabshoff/release-
cycle/sage-3.2.2.rc0/devel/sage/sage/modular/congroup.py", line 540, in
__main__.example_25
Failed example:
Gamma0(Integer(36)).cusps()###line 514:_sage_ >>>
Gamma0(36).cusps()
Expected:
{1/6, 1/4, 1/3, 1/2, 1/9, 0, 1/18, 5/12, Infinity, 1/12, 2/3, 5/6}
Got:
{1/2, 0, 1/3, 1/12, 5/6, 5/12, 1/4, 1/18, 1/6, 1/9, 2/3, Infinity}
**********************************************************************
File "/scratch/mabshoff/release-
cycle/sage-3.2.2.rc0/devel/sage/sage/modular/congroup.py", line 1064, in
__main__.example_48
Failed example:
Gamma1(Integer(5))._find_cusps()###line 1283:_sage_ >>>
Gamma1(5)._find_cusps()Expected:
{0, Infinity, 1/2, 2/5}
Got: {0, 1/2, Infinity, 2/5}
**********************************************************************
File "/scratch/mabshoff/release-
cycle/sage-3.2.2.rc0/devel/sage/sage/modular/congroup.py", line 1066, in
__main__.example_48
Failed example:
Gamma1(Integer(35))._find_cusps()###line 1285:_sage_ >>>
Gamma1(35)._find_cusps()
Expected:
{3/35, 9/10, 9/14, 11/35, 3/14, 9/35, 3/10, 11/14, 8/35, 4/7, 8/15,
Infinity, 13/14, 16/35, 13/35, 0, 4/15, 1/13, 2/35, 1/11, 1/10, 1/17, 1/1
6, 1/15, 1/14, 1/7, 1/6, 1/5, 1/4, 1/3, 1/2, 6/35, 1/9, 1/8, 6/7, 3/5,
3/7, 7/10, 4/35, 2/5, 17/35, 2/7, 5/7, 1/12, 4/5, 5/14, 12/35, 2/15}
Got:
{4/7, 1/3, 3/35, 16/35, 1/17, 1/15, 6/35, 1/6, 11/14, 3/7, 2/5, 1/11,
4/35, 3/14, 1/2, 6/7, 3/10, 1/14, 1/5, 2/35, 7/10, 5/7, 1/10, 8/15, 0,
9/14, 13/35, 4/5, 1/13, 1/4, 11/35, 9/10, 1/9, 8/35, Infinity, 12/35, 3/5,
2/7, 1/12, 13/14, 4/15, 9/35, 5/14, 1/8, 17/35, 1/7, 2/15, 1/16}
**********************************************************************
File "/scratch/mabshoff/release-
cycle/sage-3.2.2.rc0/devel/sage/sage/modular/congroup.py", line 1397, in
__main__.example_65
Failed example:
Gamma0(Integer(90))._find_cusps()###line 1681:_sage_ >>>
Gamma0(90)._find_cusps()
Expected:
{1/6, 1/5, 1/3, 1/2, 11/30, 1/9, 2/3, 1/30, Infinity, 5/6, 1/45, 0,
1/18, 1/10, 1/15, 2/15}
Got:
{0, 1/3, 11/30, 5/6, 1/15, 1/10, 2/3, 1/9, Infinity, 1/2, 1/45, 1/18,
1/5, 2/15, 1/6, 1/30}
**********************************************************************
}}}
Thoughts?
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4747#comment:6>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
