#4859: [with patch, needs review] basic covering design module
---------------------------+------------------------------------------------
Reporter: dgordon | Owner: mhansen
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4
Component: combinatorics | Resolution:
Keywords: |
---------------------------+------------------------------------------------
Comment (by wdj):
Two minor comments:
(1) I'm confused by this docstring
{{{
A $(v,k,t)$ covering design $C$ is an incidence structure ...
}}}
combined with this behaviour:
{{{
sage: C = best_known_covering_design_www(7, 3, 2); C
<class 'sage.combinat.designs.covering_design.CoveringDesign'>
sage: D = C.incidence_structure
sage: type(D)
<class 'sage.combinat.designs.incidence_structures.IncidenceStructure'>
}}}
D is an incidence structure but the way of creating D seems slightly
nonstandard.
Why not
{{{
sage: D = C.incidence_structure()
}}}
instead? I'm not saying change this, just wondering why it is the way it
is.
(2) For future reference, the patch naming is slightly non-standard
(trac_4859-covering-designs.patch or something like that is more typical).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4859#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
