#4676: [with patch, positive review pending changes] Polyhedral improvements
----------------------------------+-----------------------------------------
Reporter: mhampton | Owner: mhampton
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.4
Component: geometry | Resolution:
Keywords: polyhedra, polytopes |
----------------------------------+-----------------------------------------
Changes (by abergeron):
* summary: [with patch, needs review] Polyhedral improvements => [with
patch, positive review pending changes]
Polyhedral improvements
Comment:
Only two small stylistic points:
- Gale_transform() -> gale_transform()
- Schlegel_transform() -> schlegel_transform()
I don't think it's good style to have methods begin with a capital, even
when they refer to a person's name.
Otherwise, I don't know since when I was familiar with the math involved.
I did look up references though, and everything looks good.
If the two points above are fixed, then I give it a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4676#comment:5>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
