#4885: [with patch; needs review] fix fallout from sloppy review of 4535
----------------------+-----------------------------------------------------
Reporter: was | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.2.3
Component: graphics | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by was):
The idea is good. I don't like that you replaced:
{{{
> WARNING: The returned dictionary is mutable, but changing it does
> not change the xmin/xmax/ymin/ymax data. To change that, call
> the methods xmin, xmax, ymin, and ymax.
}}}
by
{{{
> Note that this is recomputed every time the function is called.
}}}
The first is very clear and explicit, but of course not right anymore.
The second implicitly suggests what the first said. The WARNING would be
a good place to make it clear that it doesn't make sense to change the
minmax data, since it's a function of the actual points in the objects.
And there one could point to the other relevant functions for setting the
axes ranges.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4885#comment:9>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
