#4897: [with patch, positive review, needs doctest fix] integral_points() misses
some points
--------------------------------------------+-------------------------------
Reporter: cremona | Owner: was
Type: defect | Status: new
Priority: major | Milestone: sage-3.3
Component: number theory | Resolution:
Keywords: elliptic curve integral points |
--------------------------------------------+-------------------------------
Changes (by mabshoff):
* summary: [with patch, positive review] integral_points() misses some
points => [with patch, positive review, needs
doctest fix] integral_points() misses some
points
* milestone: sage-3.4.1 => sage-3.3
Comment:
This patch causes a doctest failure without the database installed:
{{{
sage -t "devel/sage/sage/schemes/elliptic_curves/ell_rational_field.py"
**********************************************************************
File
"/scratch/mabshoff/sage-3.3.alpha0/devel/sage/sage/schemes/elliptic_curves/ell_rational_field.py",
line 4305:
sage: [P[0] for P in EllipticCurve('20160bg2').integral_points()]
Exception raised:
Traceback (most recent call last):
File
"/home/mabshoff/build/sage-3.2.4-cycle/sage-3.2.4.alpha0/local/bin/ncadoctest.py",
line 1231, in run_one_test
self.run_one_example(test, example, filename, compileflags)
File
"/home/mabshoff/build/sage-3.2.4-cycle/sage-3.2.4.alpha0/local/bin/sagedoctest.py",
line 38, in run_one_example
OrigDocTestRunner.run_one_example(self, test, example, filename,
compileflags)
File
"/home/mabshoff/build/sage-3.2.4-cycle/sage-3.2.4.alpha0/local/bin/ncadoctest.py",
line 1172, in run_one_example
compileflags, 1) in test.globs
File "<doctest __main__.example_109[14]>", line 1, in <module>
[P[Integer(0)] for P in
EllipticCurve('20160bg2').integral_points()]###line 4305:
sage: [P[0] for P in EllipticCurve('20160bg2').integral_points()]
File "/scratch/mabshoff/sage-3.3.alpha0/local/lib/python2.5/site-
packages/sage/schemes/elliptic_curves/constructor.py", line 124, in
EllipticCurve
return ell_rational_field.EllipticCurve_rational_field(x)
File "/scratch/mabshoff/sage-3.3.alpha0/local/lib/python2.5/site-
packages/sage/schemes/elliptic_curves/ell_rational_field.py", line 121, in
__init__
X = sage.databases.cremona.CremonaDatabase()[label]
File "/scratch/mabshoff/sage-3.3.alpha0/local/lib/python2.5/site-
packages/sage/databases/cremona.py", line 349, in __getitem__
return self.elliptic_curve(N)
File "/scratch/mabshoff/sage-3.3.alpha0/local/lib/python2.5/site-
packages/sage/databases/cremona.py", line 487, in elliptic_curve
raise RuntimeError, "No such elliptic curve in the database (note:
use lower case letters!)"
RuntimeError: No such elliptic curve in the database (note: use lower
case letters!)
**********************************************************************
}}}
Thoughts?
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4897#comment:6>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
