#4831: [with patch, positive review] More number field ideal utilities
-------------------------------------------+--------------------------------
 Reporter:  cremona                        |        Owner:  was       
     Type:  enhancement                    |       Status:  new       
 Priority:  major                          |    Milestone:  sage-3.4.1
Component:  number theory                  |   Resolution:            
 Keywords:  number fields, orders, ideals  |  
-------------------------------------------+--------------------------------
Changes (by davidloeffler):

  * summary:  [with patch, needs review] More number field ideal utilities
              => [with patch, positive review] More number
              field ideal utilities

Comment:

 Patch applies fine under 3.2.3; all tests in sage/rings/number_field pass;
 code looks fine and is very clearly laid out; and some experimentation
 with various random absolute number fields works fine. (I tried to test it
 for relative number fields, but they are currently so broken that I didn't
 succeed in even creating the objects to test it on.)

 I like the element_1_mod function, but there is a natural generalisation:
 given ideals I, J which are not assumed coprime, one might want a function
 that expresses a given element of I + J as a sum of elements of I and J.
 But if anyone really wants this we can have a separate ticket for it.

 My one reservation is that the docstrings will need tweaking for
 compatibility with the new ReST system. Other than that I think this is
 fine to go in.

 David

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4831#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of 
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to