#4973: [with patch, needs review] rewrite the function __getitem__ in
matrix0.pyx
to not explicitly use the python/C api
----------------------+-----------------------------------------------------
Reporter: mabshoff | Owner: jason
Type: defect | Status: assigned
Priority: major | Milestone: sage-3.3
Component: misc | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Comment (by craigcitro):
So I've reviewed Jason's patch, and everything looks good -- except that
for lots of cases, in particular the primary `M[i,j]` use case, things are
noticeably slower (on the order of 25%). This is no good on such a basic
operation.
This code actually does '''more''' than the previous version (i.e. accepts
additional types, negative indices, etc), and is still the same speed.
Cython doesn't quite do everything we want to get maximal speed out of
this call. I'm going to submit another patch that uses it more
judiciously, but gets yet more speed, because this is such an important
piece of code.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4973#comment:8>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
