#4966: [with spkg, patch, positive review] Switch gmp to eMPIRe svn1555
----------------------+-----------------------------------------------------
Reporter: mabshoff | Owner: mabshoff
Type: defect | Status: assigned
Priority: critical | Milestone: sage-3.3
Component: packages | Resolution:
Keywords: |
----------------------+-----------------------------------------------------
Changes (by was):
* summary: [with spkg, patch, needs review] Switch gmp to eMPIRe svn1555
=> [with spkg, patch, positive review] Switch
gmp to eMPIRe svn1555
Comment:
REVIEW:
(1) All doctests pass with the applied patches.
(2)
Just for fun I checked to see how bad the xgcd speed regression is:
{{{
BEFORE (with GMP):
sage: n = ZZ.random_element(0,2^(2^20)); m = ZZ.random_element(0,2^(2^20))
sage: time k = m.xgcd(n)
CPU times: user 0.73 s, sys: 0.00 s, total: 0.73 s
Wall time: 0.74 s
AFTER (with eMPIRe):
sage: n = ZZ.random_element(0,2^(2^20)); m = ZZ.random_element(0,2^(2^20))
sage: time k = m.xgcd(n)
CPU times: user 2.39 s, sys: 0.00 s, total: 2.39 s
Wall time: 2.39 s
}}}
I did some multiplication timings (by multiplying m, n as above and
bigger) and empire is always about 3-5% FASTER.
preliminary *positive review*.
I will look this over again a little more carefully, but so far it looks
very very good.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4966#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
